Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(visit): Add path-aware variants #5073

Merged
merged 205 commits into from
Jul 5, 2022
Merged

feat(visit): Add path-aware variants #5073

Changes from 1 commit
Commits
Show all changes
205 commits
Select commit Hold shift + click to select a range
ff38884
ADR
kdy1 Jun 30, 2022
4ab7b1c
Typo
kdy1 Jun 30, 2022
c12eb1a
Doc
kdy1 Jul 1, 2022
dd3d591
ADR
kdy1 Jul 1, 2022
26f1ed7
ADT
kdy1 Jul 1, 2022
8dd579c
Doc!
kdy1 Jul 1, 2022
7e73e14
Doc
kdy1 Jul 1, 2022
1ea5343
cargo feature
kdy1 Jul 1, 2022
8124b6b
path
kdy1 Jul 1, 2022
1a4d05e
docsrs
kdy1 Jul 1, 2022
1508b07
Cleanup
kdy1 Jul 1, 2022
6decd1f
fixup
kdy1 Jul 1, 2022
8065b8a
Small cleanup
kdy1 Jul 1, 2022
cd12e34
Fix one
kdy1 Jul 1, 2022
a27e864
fixup
kdy1 Jul 1, 2022
7b40655
Use field
kdy1 Jul 1, 2022
b5d14b3
fixup
kdy1 Jul 1, 2022
1a021c8
fixup
kdy1 Jul 1, 2022
d455469
fixup
kdy1 Jul 1, 2022
82b9185
VisitorVariant
kdy1 Jul 1, 2022
158c4bd
Some fix
kdy1 Jul 1, 2022
1a5a16b
`visitor_variant()`
kdy1 Jul 1, 2022
88d56c6
fixup
kdy1 Jul 1, 2022
6405d6c
More fix
kdy1 Jul 1, 2022
9d5a640
ast path type
kdy1 Jul 1, 2022
fc39159
Remove top level functions for with path variant
kdy1 Jul 1, 2022
b1be7ad
Small fix
kdy1 Jul 1, 2022
3da7d0c
fixup
kdy1 Jul 1, 2022
b58cef0
More fix
kdy1 Jul 1, 2022
a17b4aa
More fix
kdy1 Jul 1, 2022
2915aa8
fixup
kdy1 Jul 1, 2022
f9f7bcb
Rename
kdy1 Jul 1, 2022
7cb0c66
More fix
kdy1 Jul 1, 2022
69660f3
Hmm
kdy1 Jul 1, 2022
d7c07c1
API
kdy1 Jul 1, 2022
6f5d3d0
More
kdy1 Jul 1, 2022
c0f4062
More
kdy1 Jul 1, 2022
cb55a3b
fixup
kdy1 Jul 1, 2022
20c419d
fixup
kdy1 Jul 1, 2022
618e02a
More work
kdy1 Jul 1, 2022
3b5b0bd
MOre
kdy1 Jul 1, 2022
5456787
More fix
kdy1 Jul 1, 2022
eb65c07
TODO
kdy1 Jul 1, 2022
3943998
Fix var names
kdy1 Jul 1, 2022
eaec20e
Create methods
kdy1 Jul 1, 2022
a3bb51b
More
kdy1 Jul 1, 2022
eeabee3
Rename
kdy1 Jul 1, 2022
0ad5421
Rename again
kdy1 Jul 1, 2022
9663c21
Types
kdy1 Jul 1, 2022
911ee56
Use those types
kdy1 Jul 1, 2022
434711a
More
kdy1 Jul 1, 2022
1d8ebfa
Fix
kdy1 Jul 1, 2022
a99baa2
Some more work
kdy1 Jul 1, 2022
da31394
Consistent
kdy1 Jul 1, 2022
8ffcdcd
params
kdy1 Jul 1, 2022
0ba0bf0
Generic
kdy1 Jul 1, 2022
49ac014
Patch mroe
kdy1 Jul 1, 2022
ee20d32
Generics
kdy1 Jul 1, 2022
0068d25
VisitMutWithPath
kdy1 Jul 1, 2022
443dfde
Visit with path
kdy1 Jul 1, 2022
0521f77
More
kdy1 Jul 1, 2022
01a1b66
Use type alias
kdy1 Jul 1, 2022
74d473e
Fix
kdy1 Jul 1, 2022
8d5faa8
lifetime
kdy1 Jul 1, 2022
2db0d73
More fix
kdy1 Jul 1, 2022
ae77e9c
More traits
kdy1 Jul 1, 2022
dce7d10
Small fix
kdy1 Jul 1, 2022
a724544
More fix
kdy1 Jul 1, 2022
89cfd5d
fixup
kdy1 Jul 1, 2022
22b0ba2
fixup
kdy1 Jul 1, 2022
617770c
Fix
kdy1 Jul 1, 2022
78c6930
More fix
kdy1 Jul 1, 2022
a71a0ca
More fix
kdy1 Jul 1, 2022
8a40fd5
More fix
kdy1 Jul 1, 2022
7e4a32b
More fix
kdy1 Jul 1, 2022
6409ae3
Fix regression
kdy1 Jul 1, 2022
04aa156
More fix
kdy1 Jul 1, 2022
d59162f
enums
kdy1 Jul 4, 2022
3f0a554
lifetime
kdy1 Jul 4, 2022
724fb7d
More work for ebnum
kdy1 Jul 4, 2022
2cbeeab
skip variant less enums
kdy1 Jul 4, 2022
c528aa3
derive
kdy1 Jul 4, 2022
7ad84a6
Some fix
kdy1 Jul 4, 2022
f1ffc6f
Adjust
kdy1 Jul 4, 2022
4f665f7
Adjust more
kdy1 Jul 4, 2022
6bdee0e
Fix
kdy1 Jul 4, 2022
5bb47cd
More fix
kdy1 Jul 4, 2022
ca1b4d0
More fix
kdy1 Jul 4, 2022
2a0d70a
More fix
kdy1 Jul 4, 2022
65dbde1
trait
kdy1 Jul 4, 2022
4c6b9ae
More work for astkind/node ref
kdy1 Jul 4, 2022
779ae7b
fixup
kdy1 Jul 4, 2022
c524dee
Rename
kdy1 Jul 4, 2022
7c2cd98
import
kdy1 Jul 4, 2022
37c06a1
lib
kdy1 Jul 4, 2022
7ed3bae
More lib work
kdy1 Jul 4, 2022
86f8d98
More codegen work
kdy1 Jul 4, 2022
dc1dc45
types
kdy1 Jul 4, 2022
0b5472a
enum
kdy1 Jul 4, 2022
be020e3
More
kdy1 Jul 4, 2022
4d5b52c
fixup
kdy1 Jul 4, 2022
df58edd
fixup
kdy1 Jul 4, 2022
4409eb1
dedup
kdy1 Jul 4, 2022
c6d4a5e
Fix
kdy1 Jul 4, 2022
db24db6
More
kdy1 Jul 4, 2022
36660c8
name
kdy1 Jul 4, 2022
5cceda8
deref
kdy1 Jul 4, 2022
d81871f
More
kdy1 Jul 4, 2022
864054e
Arc
kdy1 Jul 4, 2022
ff6c6b9
unwrap ref
kdy1 Jul 4, 2022
035ee20
Rename
kdy1 Jul 4, 2022
a3ae6cf
More expand
kdy1 Jul 4, 2022
5c240ca
gitignore
kdy1 Jul 4, 2022
dc05868
fixup
kdy1 Jul 4, 2022
2c3d657
fixup
kdy1 Jul 4, 2022
4ca1885
fixup
kdy1 Jul 4, 2022
e8a087e
filter
kdy1 Jul 4, 2022
bdbe0f5
lints
kdy1 Jul 4, 2022
393895a
Vec<T>
kdy1 Jul 4, 2022
e378bf5
Fix
kdy1 Jul 4, 2022
9698933
lifetime
kdy1 Jul 4, 2022
d300b5a
Fix
kdy1 Jul 4, 2022
89dee19
lifetime
kdy1 Jul 4, 2022
74dc533
impl
kdy1 Jul 4, 2022
9eecee7
Change constraint
kdy1 Jul 4, 2022
1782a0f
Hmm
kdy1 Jul 4, 2022
b56fa22
Fix []
kdy1 Jul 4, 2022
9de48ac
extract generic
kdy1 Jul 4, 2022
7d87a58
Extract `to_kind_expr`
kdy1 Jul 4, 2022
1b080ce
fixup
kdy1 Jul 4, 2022
7055fae
More
kdy1 Jul 4, 2022
408436e
Fix
kdy1 Jul 4, 2022
3ea8101
Preserve
kdy1 Jul 4, 2022
973cd79
Enum variant type
kdy1 Jul 4, 2022
41ae071
More
kdy1 Jul 4, 2022
b3cf851
Fix
kdy1 Jul 4, 2022
3d30927
fixup
kdy1 Jul 4, 2022
0d0fa17
Extract
kdy1 Jul 4, 2022
d6cd60a
`'ast`
kdy1 Jul 4, 2022
44c6a62
fixup
kdy1 Jul 4, 2022
874ef91
Fix &'ast
kdy1 Jul 4, 2022
35a9157
Inject some `'ast`
kdy1 Jul 4, 2022
9f2c4a9
fixup
kdy1 Jul 4, 2022
b24f6f7
Lifetime
kdy1 Jul 4, 2022
e59c488
More
kdy1 Jul 4, 2022
af5292a
Deref
kdy1 Jul 4, 2022
2e55939
lifetime
kdy1 Jul 4, 2022
fdacd24
Copy
kdy1 Jul 4, 2022
b166a0d
Fix
kdy1 Jul 4, 2022
4428389
fixup
kdy1 Jul 4, 2022
eabeb7b
bound
kdy1 Jul 4, 2022
0501edc
Remove `'ast`
kdy1 Jul 4, 2022
21594ca
fixup
kdy1 Jul 4, 2022
6f3647f
Remove lifetime param
kdy1 Jul 4, 2022
484cd46
Bound
kdy1 Jul 4, 2022
7de359f
fixup
kdy1 Jul 4, 2022
bcede38
Declare mroe
kdy1 Jul 4, 2022
dbbd238
fixup
kdy1 Jul 4, 2022
b8489ac
More
kdy1 Jul 4, 2022
dbf833f
Declare
kdy1 Jul 4, 2022
c81c7d9
Fix
kdy1 Jul 4, 2022
f25decc
type ann
kdy1 Jul 4, 2022
dcefbf7
Fix
kdy1 Jul 4, 2022
0dc43bd
Rename
kdy1 Jul 4, 2022
7f57576
Type
kdy1 Jul 4, 2022
2c52013
Option
kdy1 Jul 4, 2022
1a64a99
WIP
kdy1 Jul 4, 2022
abbf162
More fix
kdy1 Jul 4, 2022
56d1829
Fix
kdy1 Jul 4, 2022
ff2b90b
ast_enum_variant_name
kdy1 Jul 4, 2022
119518c
fixup
kdy1 Jul 4, 2022
2b6dbfd
working
kdy1 Jul 4, 2022
2c03aa5
lints
kdy1 Jul 4, 2022
8130e90
lints
kdy1 Jul 4, 2022
524dc18
Fix
kdy1 Jul 4, 2022
6d618f4
Box
kdy1 Jul 5, 2022
e1e5e32
Box
kdy1 Jul 5, 2022
c71850b
skip
kdy1 Jul 5, 2022
51baf4a
Harden test
kdy1 Jul 5, 2022
0ec9d77
fixup
kdy1 Jul 5, 2022
e73f51b
skip
kdy1 Jul 5, 2022
6842b46
Fix Vec<Box>
kdy1 Jul 5, 2022
1bd90de
msg
kdy1 Jul 5, 2022
434a09f
Fix panic
kdy1 Jul 5, 2022
c110ce5
Fix
kdy1 Jul 5, 2022
3c61121
fixup
kdy1 Jul 5, 2022
234b946
fixup
kdy1 Jul 5, 2022
ca9bb2e
fixup
kdy1 Jul 5, 2022
226fafb
More cleanup
kdy1 Jul 5, 2022
730c67d
fixup
kdy1 Jul 5, 2022
d45cd1b
fixup
kdy1 Jul 5, 2022
086b4f6
Option<Box>
kdy1 Jul 5, 2022
0cea0be
More fix
kdy1 Jul 5, 2022
8199d48
Cleanup
kdy1 Jul 5, 2022
658a597
WIP: feature
kdy1 Jul 5, 2022
2471af1
fixup
kdy1 Jul 5, 2022
bb657fa
fixup
kdy1 Jul 5, 2022
f991dea
fix
kdy1 Jul 5, 2022
379f49a
feature gate
kdy1 Jul 5, 2022
ac3a00c
extract
kdy1 Jul 5, 2022
fa07502
More feature flag
kdy1 Jul 5, 2022
4907051
fixup
kdy1 Jul 5, 2022
2b3fc74
fixup
kdy1 Jul 5, 2022
f0a6e1b
Merge branch 'main' into smarter-visitor
swc-bot Jul 5, 2022
86feefb
Merge branch 'main' into smarter-visitor
swc-bot Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@kdy1
kdy1 committed Jul 5, 2022
commit 730c67d731d5d7a048e911bee48a279e025d2873
2 changes: 1 addition & 1 deletion crates/swc_visit_macros/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ fn make(mode: Mode, stmts: &[Stmt]) -> Quote {
)),

Mode::Fold(VisitorVariant::WithPath) => {
if Some(ast_enum_variant_name) = ast_enum_variant_name(arg_ty, false) {
if let Some(ast_enum_variant_name) = ast_enum_variant_name(arg_ty, false) {
tokens.push_tokens(&q!(
Vars {
fn_name,
Expand Down