Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scsynth: set SC_ServerBootDelayWarning as source to scsynth #5012

Merged
merged 2 commits into from
Jun 13, 2020
Merged

scsynth: set SC_ServerBootDelayWarning as source to scsynth #5012

merged 2 commits into from
Jun 13, 2020

Conversation

sonoro1234
Copy link
Contributor

scsynth: set SC_ServerBootDelayWarning as source to scsynth not to libscsynth solves #4992

mossheim
mossheim reviewed Jun 13, 2020
View reviewed changes
Copy link
Contributor

@mossheim mossheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! can you please make the equivalent change to supernova as well? partially to keep things consistent, partially in case libsupernova also becomes a shared library.

@sonoro1234
Copy link
Contributor Author

can you please make the equivalent change to supernova as well

It seems not necessary as supernova doesnt have internal server

@mossheim
Copy link
Contributor

it would still lead to some confusion if in the future libsupernova were built as a shared lib for another reason, and again it is also more consistent, so please change it while we have the problem and solution fresh in our minds. :)

@sonoro1234
Copy link
Contributor Author

so please change it while we have the problem and solution fresh in our minds

You are right. Done

mossheim
mossheim approved these changes Jun 13, 2020
View reviewed changes
Copy link
Contributor

@mossheim mossheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mossheim
Copy link
Contributor

oh, almost forgot -- the libscsynth option will still be broken on macOS due to this - #4992 (comment) . that one is a bit more complicated to handle because the eventloop stuff and disableAppNap are in the same header. i think i know a way to manage it, and i have a mac to test on. i will open a separate PR after this one.

after this PR i'll also add a job to #4906 for Linux+LIBSCSYNTH.

@mossheim mossheim merged commit 8ff50ef into supercollider:develop Jun 13, 2020
This was referenced Jun 13, 2020
Closed
Closed
@sonoro1234 sonoro1234 deleted the delwarn branch June 13, 2020 18:13
@mossheim mossheim mentioned this pull request Jun 13, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mossheim mossheim mossheim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonoro1234 @mossheim