-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[classlib] Plotter: correct resampling of domain given fixed Array:series method. #4510
[classlib] Plotter: correct resampling of domain given fixed Array:series method. #4510
Conversation
Related: #4223, and #4459, are closely tied to this part of the code (Plotter), and have already been reviewed and approved, and have a |
and thanks, @snappizz for reporting the issue! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jeez sorry it took me so long to get around to this. looks good, thanks!
Thanks @snappizz for the follow up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Purpose and Motivation
Fixes #4505, which came up as an issue after #4454 broke #4082.
The way the plot's domain values were previously calculated, accumulated resolution error meant that
Array:series
prevented the domain from reaching its upper boundary in some cases (before #4454,Array:series
would overshoot its end value), which in turn meant the domain array would be one value less than the data coordinate array.This fix replace Array:series with Array:interpolation to resample the domain, ensuring the domain hits the last value and its size matches exactly with the data coordinate array.
An example of the difference between the two methods:
Types of changes
To-do list
- [ ] Updated documentation