UnitTest: add debug method #3623
Conversation
|
Do I understand it correctly: the isolation problem you have run into comes from the fact that you need some instance variables that are local to the test-method. This could be achieved by local variables in the method. But you want to access these variables in the context from which the test-method is called. So you are looking for a good place to store the debug string that grows over several |
|
^ That should be a comment on the issue, not on this PR. But no, you could have isolation and still run setup and teardown. |
|
Replied in #3572. |
There was a problem hiding this comment.
IIUC resetDebug should be a private method; there's currently no reason for it to be called from within a test, and you've provided no documentation for it while you have for debug. Plus it just seems like the kind of implementation detail we wouldn't want to be part of the public interface. I'm skeptical of calling it from within UnitTestResult.
|
I've added an implementation that guarantees isolated methods (#3624). Let's first finish that one and then the debug can be added easily. |
|
#3836 has fixed the test isolation problem, so this needs to be reworked now. |
This allows TestCases to provide debug which will be displayed in the
results report along with any details from assertions, except for
passing tests where brief reporting has been requested via
UnitTest.passVerbosity = UnitTest.brief;
This is very similar to the addDetail method in Python's testtools:
https://testtools.readthedocs.io/en/latest/for-test-authors.html#details
Partially addresses supercollider#3365.
There was a problem hiding this comment.
This looks fine to me AFAICS. @brianlheim and @telephon are you happy with this?
yeah, it looks good to me |
This allows TestCases to provide debug which will be displayed in the results report along with any details from assertions, except for passing tests where brief reporting has been requested via
This is very similar to the
addDetailmethod in Python's testtools.Unfortunately UnitTest doesn't provide isolation between test cases as per #3572, so we have to reset the debug state after each test method, otherwise debug from one test method can bleed into the next if brief reporting is enabled and all the tests in the first one pass.
Partially addresses #3365.