-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub issue & PR templates #3017
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1e05934
Add GitHub issue & PR templates
mossheim 8c401ce
Issue template: move environment section to the top
mossheim 930a878
Issue template: remove context section
mossheim d6f4558
Issue template: move Possible Solution section to end, clearly mark a…
mossheim 8531bcc
Issue template: add thank-you to end
mossheim a964faf
Pull request template: merge purpose & motivation/context sections
mossheim 29ec5ba
Pull request template: add checkbox and comment for listing work to do
mossheim 0eeb61a
Pull request template: update wording of checklist
mossheim ca74afa
Issue template: encourage users to post full stack trace
mossheim 2a172c9
Issue template: remove possible solution section
mossheim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
<!--- Provide a general summary of the issue in the Title above --> | ||
|
||
## Environment | ||
* SuperCollider version: | ||
* Operating system and version: | ||
<!--- Include any other relevant details about your environment (Qt version, audio driver, etc.) --> | ||
|
||
## Expected Behavior | ||
<!--- If you're describing a bug, tell us what should happen --> | ||
<!--- If you're suggesting a change/improvement, tell us how it should work --> | ||
|
||
## Current Behavior | ||
<!--- If describing a bug, tell us what happens instead of the expected behavior --> | ||
<!--- If suggesting a change/improvement, explain the difference from current behavior --> | ||
|
||
## Steps to reproduce (for bugs) | ||
|
||
```supercollider | ||
// Please paste SuperCollider code here. | ||
// Try to make your example as minimal as possible. | ||
``` | ||
|
||
## Error message (for bugs) | ||
|
||
``` | ||
// Please paste any error messages here in their entirety. | ||
// If this is a SuperCollider error message, include the full stack trace. | ||
// Link to a Gist (https://gist.github.com) if the message is long. | ||
``` | ||
|
||
<!--- Thanks for contributing! --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
<!--- Provide a general summary of your changes in the title above --> | ||
|
||
## Purpose and Motivation | ||
|
||
<!--- Please describe the purpose and motivation of the pull request. --> | ||
<!--- Why is this change required? What problem does it solve? --> | ||
<!--- If it fixes an open issue, please link to the issue here. --> | ||
|
||
## Types of changes | ||
|
||
<!--- What types of changes does your pull request introduce? Put an `x` in all the boxes that apply: --> | ||
- [ ] Documentation (non-code change which corrects or adds documentation for existing features) | ||
- [ ] Bug fix (non-breaking change which fixes an issue) | ||
- [ ] New feature (non-breaking change which adds functionality) | ||
- [ ] Breaking change (fix or feature that would cause existing functionality to change) | ||
|
||
## Checklist | ||
|
||
- [ ] All tests are passing | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we ask for tests, there should be a link on how to do the tests (since this is not on per default in vanilla SC) |
||
- [ ] If necessary, new tests were created to address changes in PR (and tests are passing) | ||
- [ ] Updated documentation, if necessary | ||
- [ ] This PR is ready for review | ||
|
||
<!--- If any work remains to be done, please give a brief description here. --> | ||
<!--- Consider providing a todo-list so we can easily track completion progress. --> | ||
|
||
<!--- Thanks for contributing! --> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checklist is to fill out over the course of the PR, no? Or what is the intention of having checkboxes to tick?