Handle spaces in SCDoc internal links #2135
Conversation
Conflicts: editors/scvim
nhthn
added
comp: SCDoc
|
@jamshark70 any comments? |
| @@ -396,11 +402,11 @@ SCDocHTMLRenderer { | |||
| stream << "<span class='soft'>" << this.escapeSpecialChars(node.text) << "</span>"; | |||
| }, | |||
| \ANCHOR, { | |||
| stream << "<a class='anchor' name='" << node.text << "'> </a>"; | |||
| stream << "<a class='anchor' name='" << this.escapeSpacesInAnchor(node.text) << "'> </a>"; | |||
There was a problem hiding this comment.
The spacing is off here. Shouldn't introduce all that white space; it should be even with the other ones on the page.
There was a problem hiding this comment.
damnit, this is why spaces > tabs
|
builds fine, help appears to be fine. I am still looking for a link with a # and a space in it. I searched the docs and don't find any. maybe Emacs Editor Emacs shortcut, check out this link::http://lpn.rnbhq.org/tools/xemacs/emacs_ref.html##Emacs reference::. but that generates http://lpn.rnbhq.org/tools/xemacs/emacs_ref.html ah but the ## here are part of schelp markup and the link there is dead anyway (the domain is gone) |
|
btw. here is a test with encodeURI: |
|
@snappizz can you enable the checkbox for "allow maintainers to contribute" (on the right side of this) That would allow me to more easily fix the conflict. Of course you can fix the conflict too if you want. |
|
done. have at it! |
|
conflict fixed and ready to merge here: #2135 |
Fixes #1650. I cherrypicked a451a06 because I was too lazy to figure out how to properly deal with the scvim submodule. (If I tried to checkout James' branch then I got an error that the scvim directory would be overwritten.)
@jamshark70 Please try this and let me know if it fixes the bug. I can't reproduce it in Firefox.