Merge pull request #4028 from supercollider/topic/UnitTestInfo

Topic/unit test info
supercollider · Sep 9, 2018 · a37645f · a37645f
2 parents b284f98 + 9b4ac9b
commit a37645f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -24,8 +24,8 @@ Checklist
 
 <!--- Complete an item by checking it: [x] -->
 
-- [ ] All tests are passing
-- [ ] If necessary, new tests were created to address changes in PR, and tests are passing
+- [ ] All previous tests are passing
+- [ ] Tests were updated or created to address changes in this PR, and tests are passing
 - [ ] Updated documentation, if necessary
 - [ ] This PR is ready for review
 

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -91,7 +91,7 @@ Please be as descriptive as possible when creating an issue. In order for us to
 	        the component being changed. The body describes the behavior without the patch,
 	        why this is a problem, and how the patch fixes the problem when applied.
 
-- Make sure you have added the necessary tests for your changes.
+- Make sure you have added the necessary tests for your changes. All changes to code should include a test which checks for correct functionality, including regression tests for bug fixes. Info on best practice for Unit tests is available at https://github.com/supercollider/supercollider/wiki/Unit-Testing-Guide
 - Make sure you have documented your changes, if necessary.
 
 ### Submitting changes as Pull Requests

diff --git a/DEVELOPING.md b/DEVELOPING.md
@@ -150,12 +150,12 @@ Test Suite
 
 ### Purpose
 
-Unit testing suite for SuperCollider language core library
+Unit testing suite for SuperCollider language core library. All changes to code should include a test which checks for correct functionality, including regression tests for bug fixes.
 
 ### Usage
 
 If developing on a version older than 3.9.0, download `UnitTesting` quark separately. Add the test suite folder to your
-SuperCollider compile paths. Recompile. Run `UnitTest.runAll`, or run tests from the GUI via `UnitTest.gui`.
+SuperCollider compile paths. Recompile. Run `UnitTest.runAll`, or run tests from the GUI via `UnitTest.gui`. Info on best practice for writing unit tests can be found at (https://github.com/supercollider/supercollider/wiki/Unit-Testing-Guide)
 
 ### Continuous automatic red/green testing via guard-sclang