scide: Fix missing icon

supercollider · Jan 24, 2019 · 42b6b72 · 42b6b72
1 parent e567b99
commit 42b6b72
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 12 deletions.
diff --git a/editors/sc-ide/core/main.cpp b/editors/sc-ide/core/main.cpp
@@ -98,8 +98,9 @@ int main( int argc, char *argv[] )
     // Go...
     MainWindow *win = new MainWindow(main);
 
-    app.setWindowIcon(QIcon("qrc:///icons/sc-ide-svg"));
-
+    // Unfortunately, the SVG icon shows up as a tiny dot on some Linux window
+    // managers (see #3905, #2646). Best we can do here is a PNG.
+    // app.setWindowIcon(QIcon(":icons/sc-ide-svg"));
     // NOTE: load session after GUI is created, so that GUI can respond
     Settings::Manager *settings = main->settings();
     SessionManager *sessions = main->sessionManager();

diff --git a/editors/sc-ide/widgets/main_window.cpp b/editors/sc-ide/widgets/main_window.cpp
@@ -227,16 +227,18 @@ MainWindow::MainWindow(Main * main) :
     updateRecentDocsMenu();
 
     QIcon icon;
-    icon.addFile(":/icons/sc-ide-svg");
-    icon.addFile(":/icons/sc-ide-16");
-    icon.addFile(":/icons/sc-ide-24");
-    icon.addFile(":/icons/sc-ide-32");
-    icon.addFile(":/icons/sc-ide-48");
-    icon.addFile(":/icons/sc-ide-64");
-    icon.addFile(":/icons/sc-ide-128");
-    icon.addFile(":/icons/sc-ide-256");
-    icon.addFile(":/icons/sc-ide-512");
-    icon.addFile(":/icons/sc-ide-1024");
+    // Unfortunately, the SVG icon shows up as a tiny dot on some Linux window
+    // managers (see #3905, #2646). Best we can do here is PNGs.
+    // icon.addFile(":icons/sc-ide-svg");
+    icon.addFile(":icons/sc-ide-16");
+    icon.addFile(":icons/sc-ide-24");
+    icon.addFile(":icons/sc-ide-32");
+    icon.addFile(":icons/sc-ide-48");
+    icon.addFile(":icons/sc-ide-64");
+    icon.addFile(":icons/sc-ide-128");
+    icon.addFile(":icons/sc-ide-256");
+    icon.addFile(":icons/sc-ide-512");
+    icon.addFile(":icons/sc-ide-1024");
     QApplication::setWindowIcon(icon);
 
     updateWindowTitle();