Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoringMixer example initializes the first sample of output twice. #9

Open
mtmccrea opened this issue Oct 13, 2018 · 0 comments
Open

Comments

@mtmccrea
Copy link
Member

mtmccrea commented Oct 13, 2018

As noted in #8, set_calc_function also calls (mCalcFunc)(this, 1);.

Whether or not this is the right approach (I'm thinking probably not for the reasons in #8, as well as other Ctor/initial sample related concerns), the result is that the BoringMixer example initializes the first sample of output twice:

BoringMixer2() {
// New way of setting calc function.
set_calc_function<BoringMixer2, &BoringMixer2::next>();
next(1);
}

It would be great if the examples showed either a consistent way of initializing the first sample (if there is a consistent way), or, more likely, be explicit about when you need to use SETCALC, set_calc_function, as well as next(1), or directly set ZOUT(0). Though I realize that a larger, possibly unresolved issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant