Skip to content

Commit

Permalink
fix: enable linting changed files with textlint (#5100)
Browse files Browse the repository at this point in the history
textlint was expensive to run because we added every file in the list of
files to lint to FILE_ARRAY_NATURAL_LANGUAGE. In #5041, we mitigated
this issue but lost the ability to run textlint on changed files only.
Given that textlint ignore files for which it doesn't have a plugin
installed, and that we don't currently install additional plugins
besides the default ones to lint markdown files and text files, we let
textlint run on these files only, so we can have the feature to lint
only changed files with this linter as well, back.
  • Loading branch information
ferrarimarco authored Jan 10, 2024
1 parent 4e34d3d commit 6f70ade
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 196 deletions.
7 changes: 0 additions & 7 deletions docs/upgrade-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,6 @@ This section helps you migrate from super-linter `v5` to `v6`.
information about how to ignore files with Jscpd, see
[the Jscpd documentation](https://github.com/kucherenko/jscpd/tree/master/packages/jscpd).

### textlint

- textlint doesn't consider the `FILTER_REGEX_EXCLUDE`, `FILTER_REGEX_INCLUDE`,
`IGNORE_GENERATED_FILES`, `IGNORE_GITIGNORED_FILES` variables. For more
information about how to ignore files with textlint, see
[the textlint documentation](https://textlint.github.io/docs/ignore.html).

### USE_FIND_ALGORITHM and VALIDATE_ALL_CODEBASE used together

- Setting `USE_FIND_ALGORITHM` to `true` and `VALIDATE_ALL_CODEBASE` to `false`
Expand Down
Loading

0 comments on commit 6f70ade

Please sign in to comment.