fix: dangling open transaction for cdc-only, feat: add nats connector #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add nats connector (for cdc events) For the first part, fix START_REPLICATION cannot run inside a transaction block for CDC only, which is caused by PostgresSource::new opening a transaction, but never closing it for CDC only. This can be remedied by committing that transaction and offering an explicit start_transaction function to be called in cases of not CDC only. For the 2nd part, introduce a NATS connector (WIP, this should probably create or get a stream in Jetstream for persistence and needs some configuration options) so we can propagate out CDC events onto a message broker Refs: supabase#80
1 task
cawfeecoder
commented
Jan 1, 2025
| @@ -54,6 +55,10 @@ impl<Src: Source, Snk: BatchSink> BatchDataPipeline<Src, Snk> { | |||
| copied_tables: &HashSet<TableId>, | |||
| ) -> Result<(), PipelineError<Src::Error, Snk::Error>> { | |||
| let start = Instant::now(); | |||
| self.source | |||
There was a problem hiding this comment.
This is the fix for the transaction, by starting an explicit transaction here instead of relying on the constructor of PostgresSource to open a transaction.
cawfeecoder
commented
Jan 1, 2025
| @@ -69,6 +69,7 @@ impl PostgresSource { | |||
| let (table_names, publication) = | |||
| Self::get_table_names_and_publication(&replication_client, table_names_from).await?; | |||
| let table_schemas = replication_client.get_table_schemas(&table_names).await?; | |||
| replication_client.commit_txn().await?; | |||
There was a problem hiding this comment.
This is the fix for #80, by making sure we don't have a dangling transaction going out of the constructor. I'm not sure whether we need the transaction at all here, but erred on the side of caution.
|
@cawfeecoder thanks for the PR. Could you please break the fix for #80 into a separate PR as it helps in reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix and Feature (happy to break these into 2 seperate PRs)
What is the current behavior?
For the fix, #80. The existing behavior leaves a dangling transaction
open when calling PostgresSource::new that it expects BatchDataPipeline::copy_tables to close
What is the new behavior?
BatchDataPipeline::copy_tables explicitly requests it's own transaction and then closes it when completed. This avoids CDC only complaining about the above error since we don't use transactions during CDC only now.
I've also added a WIP NATS connector to publish out changes on a NATS message broker.
Additional context