fix(base): don't wrap JsRuntime with ManuallyDrop early (#457)

supabase · Dec 4, 2024 · 4cbeee8 · 4cbeee8
1 parent 5707665
commit 4cbeee8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/crates/base/src/deno_runtime.rs b/crates/base/src/deno_runtime.rs
@@ -691,7 +691,7 @@ where
             ..Default::default()
         };
 
-        let mut js_runtime = ManuallyDrop::new(JsRuntime::new(runtime_options));
+        let mut js_runtime = JsRuntime::new(runtime_options);
 
         let dispatch_fns = {
             let context = js_runtime.main_context();
@@ -911,7 +911,7 @@ where
 
         Ok(Self {
             drop_token,
-            js_runtime,
+            js_runtime: ManuallyDrop::new(js_runtime),
             env_vars,
             conf,
             s3_fs: maybe_s3_fs,