feat(config): add diff with remotes for auth #2814
Open
+2,031
−849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11626956411Details
💛 - Coveralls |
| result.Email.Smtp.Host = *remoteConfig.SmtpHost | ||
| } | ||
| if remoteConfig.SmtpPass != nil { | ||
| result.Email.Smtp.Pass = *remoteConfig.SmtpPass |
There was a problem hiding this comment.
I think this value is masked in api response.
sweatybridge
force-pushed
the
feat/add-auth-diff-remote
branch
from
6ebd353
to
d115c28
Compare
avallete
commented
Nov 1, 2024
| return | ||
| } | ||
| localHashed := sha256Hmac(secret, *local) | ||
| diff.CompareSensitiveField(&localHashed, remote) |
There was a problem hiding this comment.
remark
Here I still use CompareSentitiveField to keep a human readable result message. We could just use the standard comparaison over the hashed values but I think that might confuse the users wondering why the value they set in their config get a different value in their config diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
relates to #2552
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.