Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(functions): allow custom functions entrypoint path #2813

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Oct 29, 2024

What kind of change does this PR introduce?

feature

What is the new behavior?

Allow functions entrypoint to be customized, ie. functions/my-slug/index.js

TODO:

  • support arbitrary entrypoint path, ie. ../slug/sample.js

Additional context

Add any other context or screenshots.

@coveralls
Copy link

coveralls commented Oct 29, 2024

Pull Request Test Coverage Report for Build 11585965905

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 59.801%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/functions/serve/serve.go 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11576142195: -0.02%
Covered Lines: 6361
Relevant Lines: 10637

💛 - Coveralls

@sweatybridge sweatybridge merged commit 398b7b7 into develop Oct 30, 2024
9 checks passed
@sweatybridge sweatybridge deleted the er-entrypoint branch October 30, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants