Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade keyring use package DeleteAll method #2800

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

avallete
Copy link
Member

What kind of change does this PR introduce?

Thank's to the new keyring release here: zalando/go-keyring#112 (comment)

We can now use the package DeleteAll method.

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

coveralls commented Oct 25, 2024

Pull Request Test Coverage Report for Build 11516470575

Details

  • 4 of 9 (44.44%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 59.786%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/utils/credentials/store.go 4 9 44.44%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11512298294: -0.03%
Covered Lines: 6360
Relevant Lines: 10638

💛 - Coveralls

@avallete avallete marked this pull request as ready for review October 25, 2024 10:51
@avallete avallete merged commit 2fe2da6 into develop Oct 25, 2024
13 checks passed
@avallete avallete deleted the chore/use-keyring-deleteall branch October 25, 2024 11:56
@github-actions github-actions bot mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants