fix: Bump node-fetch dep to pick up security release #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-stytch
approved these changes
Jul 7, 2022
| @@ -54,6 +54,11 @@ | |||
| "isomorphic-unfetch": "^3.1.0", | |||
There was a problem hiding this comment.
I haven't dug too deep into the issue, but "Up to (excluding) 3.1.1" makes me think we should also bump our direct dependency. But I may just be misunderstanding the override system with multiple versions of the same dependency around.
Suggested change
| "isomorphic-unfetch": "^3.1.0", | |
| "isomorphic-unfetch": "^3.1.1", |
There was a problem hiding this comment.
I took a look into node-fetch and the reported issue isn't fixed in the latest - opened node-fetch/node-fetch#1599
max-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
max-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
max-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force bumps
node-fetchto 2.6.7 to resolve https://nvd.nist.gov/vuln/detail/CVE-2022-0235