Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix report() for index/endIndex zero values #7565

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Fix report() for index/endIndex zero values #7565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0bf8638
Fix end positions for CSS entities with a length of 1 at the start of…
romainmenke Mar 20, 2024
b05abc8
Merge branch 'main' into allow-endIndex-to-be-zero--generous-caiman-6…
romainmenke Mar 20, 2024
aa9a9ce
also check index and update postcss
romainmenke Mar 21, 2024
ef6928d
Merge branch 'allow-endIndex-to-be-zero--generous-caiman-66321db509' …
romainmenke Mar 21, 2024
847f8f9
Create red-fans-wait.md
romainmenke Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/red-fans-wait.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"stylelint": patch
---

Fixed: `report()` for `index`/`endIndex` zero values
4 changes: 2 additions & 2 deletions lib/utils/report.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,13 @@ function report(problem) {

if (problem.start) {
warningProperties.start = problem.start;
} else if (index) {
} else if (typeof index === 'number') {
warningProperties.index = index;
}

if (problem.end) {
warningProperties.end = problem.end;
} else if (endIndex) {
} else if (typeof endIndex === 'number') {
warningProperties.endIndex = endIndex;
}

Expand Down
4 changes: 2 additions & 2 deletions lib/utils/report.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,13 @@ export default function report(problem) {

if (problem.start) {
warningProperties.start = problem.start;
} else if (index) {
} else if (typeof index === 'number') {
warningProperties.index = index;
}

if (problem.end) {
warningProperties.end = problem.end;
} else if (endIndex) {
} else if (typeof endIndex === 'number') {
warningProperties.endIndex = endIndex;
}

Expand Down
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@
"micromatch": "^4.0.5",
"normalize-path": "^3.0.0",
"picocolors": "^1.0.0",
"postcss": "^8.4.35",
"postcss": "^8.4.38",
"postcss-resolve-nested-selector": "^0.1.1",
"postcss-safe-parser": "^7.0.0",
"postcss-selector-parser": "^6.0.16",
Expand Down
Loading