Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ranges for warnings #5725

Merged
merged 106 commits into from
Apr 11, 2022
Merged

Add ranges for warnings #5725

Changes from 1 commit
Commits
Show all changes
106 commits
Select commit Hold shift + click to select a range
63f8b37
feat: Report ranges for warnings (WIP)
adalinesimonian Nov 19, 2021
a447e4d
chore: update postcss dependency
adalinesimonian Nov 22, 2021
ec0aae0
feat: report ranges for brace space rules
adalinesimonian Nov 22, 2021
2dc1792
feat: report ranges for at rule space rules
adalinesimonian Nov 23, 2021
5165d31
feat: report ranges for block-no-empty
adalinesimonian Nov 23, 2021
42623c2
feat: report ranges for color-named
adalinesimonian Nov 23, 2021
7cfd9a1
feat: report ranges for comment-* rules
adalinesimonian Nov 23, 2021
783d7ab
feat: report ranges for custom-* rules
adalinesimonian Nov 23, 2021
8ca7b4f
feat: report ranges for declaration bang rules
adalinesimonian Nov 23, 2021
219f245
feat: report ranges for declaration-block-* rules
adalinesimonian Nov 23, 2021
e1fc99d
feat: report ranges for declaration-colon-* rules
adalinesimonian Nov 23, 2021
cf16178
feat: report ranges for declaration-no-important
adalinesimonian Nov 23, 2021
86a5976
feat: report ranges for declaration-property rules
adalinesimonian Nov 23, 2021
987a1d0
feat: report ranges for font-family rules
adalinesimonian Nov 23, 2021
9f7902b
feat: report ranges for font-weight-notation
adalinesimonian Nov 23, 2021
97a9af6
fix: correctly report ranges for declaration-block
adalinesimonian Nov 23, 2021
84315b9
feat: report ranges for function-allowed-list
adalinesimonian Nov 23, 2021
35bf606
chore: update postcss and value parser deps
adalinesimonian Nov 24, 2021
4d26553
fix: update postcss type usage
adalinesimonian Nov 24, 2021
470b1c1
feat: report ranges for function-calc-no-unspaced
adalinesimonian Nov 24, 2021
42b6194
feat: report ranges for function-comma-* rules
adalinesimonian Nov 24, 2021
9aa49de
feat: report ranges for function-disallowed-list
adalinesimonian Nov 24, 2021
6dcc6b8
feat: report ranges for function-linear-gradient
adalinesimonian Nov 24, 2021
3bbfafb
feat: report ranges for function-max-empty-lines
adalinesimonian Nov 24, 2021
e345892
feat: report ranges for function-name-case
adalinesimonian Nov 24, 2021
9872b31
feat: report ranges for function-parentheses rules
adalinesimonian Nov 24, 2021
720e7a3
feat: report ranges for function-url-* rules
adalinesimonian Nov 24, 2021
1ca0878
feat: report ranges for function-whitespace-after
adalinesimonian Nov 24, 2021
b08892f
feat: report ranges for hue-degree-notation
adalinesimonian Nov 24, 2021
ee69634
feat: report ranges for indentation
adalinesimonian Nov 24, 2021
dd5034f
feat: report ranges for keyframe rules
adalinesimonian Nov 25, 2021
e8f597e
feat: report ranges for length-zero-no-unit
adalinesimonian Nov 25, 2021
4ef5516
feat: report ranges for max-empty-lines
adalinesimonian Nov 25, 2021
f732e1f
fix: only replace empty lines in max-empty-lines
adalinesimonian Nov 25, 2021
42b5850
feat: report ranges for max-line-length
adalinesimonian Nov 26, 2021
9899bed
chore: update postcss-value-parser to 4.2.0
adalinesimonian Nov 29, 2021
94b2150
feat: report ranges for media-feature-colon rules
adalinesimonian Nov 29, 2021
77429f0
feat: report ranges for media-feature-name-* rules
adalinesimonian Nov 29, 2021
7109c96
feat: report ranges for media-feature-parentheses
adalinesimonian Nov 29, 2021
d96c7fd
feat: report ranges for media-feature-range rules
adalinesimonian Nov 29, 2021
3901a79
Merge branch 'main' into warning-ranges
adalinesimonian Dec 3, 2021
4e2a2f4
Merge branch 'main' into warning-ranges
ybiquitous Feb 10, 2022
7c6d4a4
npm i @flatten-js/interval-tree
ybiquitous Feb 10, 2022
1a4ec4b
Merge branch 'main' into warning-ranges
ybiquitous Feb 10, 2022
54d3004
Fix test failures of `tapFormatter.test.js`
ybiquitous Feb 10, 2022
1fb2d08
Fix failures of `reportUnknownRuleNames.test.js`
ybiquitous Feb 13, 2022
faeb583
Revert frozen stylistic rules
ybiquitous Feb 13, 2022
6ea49a6
Merge branch 'main' into warning-ranges
ybiquitous Feb 21, 2022
b26c3af
Merge branch 'main' into warning-ranges
ybiquitous Feb 21, 2022
732eede
Merge branch 'main' into warning-ranges
ybiquitous Feb 24, 2022
742de7a
Fix type error of `declaration-property-value-disallowed-list`
ybiquitous Feb 24, 2022
4d8114b
Refactor `utils.report()`
ybiquitous Feb 24, 2022
2d8ee0d
Update snapshots of system tests
ybiquitous Feb 24, 2022
e7b76f4
Merge branch 'main' into warning-ranges
ybiquitous Mar 7, 2022
85540e6
Fix `!important` position
ybiquitous Mar 7, 2022
ae2a753
Merge branch 'main' into warning-ranges
ybiquitous Mar 8, 2022
284f2d7
Update test for `font-family-name-quotes`
ybiquitous Mar 8, 2022
d795d24
Merge branch 'main' into warning-ranges
ybiquitous Mar 8, 2022
3f91a5f
Merge branch 'main' into warning-ranges
ybiquitous Mar 9, 2022
869bda1
Fix test failures of utlities
ybiquitous Mar 9, 2022
ea99a05
Fix test for `length-zero-no-unit`
ybiquitous Mar 9, 2022
6e14e02
Fix test for `comment-word-disallowed-list`
ybiquitous Mar 9, 2022
ec84751
Revert change and add `endIndex` for `function-calc-no-unspaced-opera…
ybiquitous Mar 10, 2022
e49d265
Merge branch 'main' into warning-ranges
ybiquitous Mar 14, 2022
19253dd
Fix column position for `declaration-block-single-line-max-declarations`
ybiquitous Mar 14, 2022
593e3ca
Fix test cases for `alpha-value-notation`
ybiquitous Mar 14, 2022
996501e
Fix test cases for `block-no-empty`
ybiquitous Mar 14, 2022
c8b937f
Add test cases for `color-hex-alpha`
ybiquitous Mar 16, 2022
e507c8e
Add test cases for `color-hex-length`
ybiquitous Mar 16, 2022
a6a741f
Add test cases for `color-named`
ybiquitous Mar 16, 2022
3053bc1
Merge branch 'main' into warning-ranges
ybiquitous Mar 27, 2022
8238dd1
Fix implementation and test for `color-function-notation`
ybiquitous Mar 27, 2022
d6e96cf
Improve test cases for `color-no-hex`
ybiquitous Mar 27, 2022
a4fdd14
Improve test cases for `color-no-invalid-hex`
ybiquitous Mar 27, 2022
a0a8a10
Improve test cases for `custom-media-pattern`
ybiquitous Mar 27, 2022
3680109
Improve test cases for `custom-property-no-missing-var-function`
ybiquitous Mar 28, 2022
9d8884d
Fix implementation and test for `custom-property-pattern`
ybiquitous Mar 28, 2022
3036f13
Merge branch 'main' into warning-ranges
ybiquitous Apr 3, 2022
be89b7d
Improve test cases for `declaration-property-unit-allowed-list`
ybiquitous Apr 3, 2022
c2cc4fb
Improve test cases for `declaration-property-unit-disallowed-list`
ybiquitous Apr 3, 2022
392e42b
Improve test cases for `declaration-property-value-allowed-list`
ybiquitous Apr 3, 2022
6681cb8
Revert implementation and improve test cases for `declaration-propert…
ybiquitous Apr 3, 2022
b011204
Improve test cases for `font-family-no-duplicate-names`
ybiquitous Apr 3, 2022
10cb336
Refactor implementation and improve test cases for `font-family-no-mi…
ybiquitous Apr 3, 2022
a5fe7e3
Merge branch 'main' into warning-ranges
ybiquitous Apr 7, 2022
f38c4c0
Fix `font-weight-notation` end position
ybiquitous Apr 7, 2022
624f2f3
Improve test cases and fix for `function-allowed-list`
ybiquitous Apr 8, 2022
efe85b5
Improve test cases for `function-disallowed-list`
ybiquitous Apr 8, 2022
fb276b0
Improve test cases for `function-linear-gradient-no-nonstandard-direc…
ybiquitous Apr 8, 2022
ecc0885
Improve test cases for `function-url-no-scheme-relative`
ybiquitous Apr 8, 2022
1aa7ac0
Improve test cases for `function-url-quotes`
ybiquitous Apr 8, 2022
7b07e74
Improve test cases for `function-url-scheme-allowed-list`
ybiquitous Apr 8, 2022
5c1149e
Improve test cases for `function-url-scheme-disallowed-list`
ybiquitous Apr 8, 2022
766a759
Improve test cases for `hue-degree-notation`
ybiquitous Apr 9, 2022
4da3094
Improve test cases for `keyframes-name-pattern`
ybiquitous Apr 9, 2022
8118d45
Improve test cases for `media-feature-name-allowed-list`
ybiquitous Apr 9, 2022
c1cac90
Improve test cases for `media-feature-name-disallowed-list`
ybiquitous Apr 9, 2022
4129cb1
Improve test cases for `media-feature-name-no-unknown`
ybiquitous Apr 9, 2022
d74f6d1
Improve test cases for `media-feature-name-value-allowed-list`
ybiquitous Apr 9, 2022
9c675ce
Remove unused `getWhitespaceEndIndex()`
ybiquitous Apr 9, 2022
2c59689
Remove unused `getWhitespaceStartIndex()`
ybiquitous Apr 9, 2022
2755c1b
Remove unused `getWordEndIndex()`
ybiquitous Apr 9, 2022
acca7dd
Remove unused `getWordStartIndex()`
ybiquitous Apr 9, 2022
952255a
Improve test case for `jsonFormatter`
ybiquitous Apr 10, 2022
13030a9
Update docs
ybiquitous Apr 11, 2022
2beb8d5
Merge branch 'main' into warning-ranges
ybiquitous Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve test cases for hue-degree-notation
  • Loading branch information
@ybiquitous
ybiquitous committed Apr 9, 2022
commit 766a7590ffd9a475988e66d1de667c854962d945
54 changes: 50 additions & 4 deletions lib/rules/hue-degree-notation/__tests__/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,34 +68,44 @@ testRule({
message: messages.expected('120', '120deg'),
line: 1,
column: 16,
endLine: 1,
endColumn: 19,
},
{
code: 'a { color: HSL(120 60% 70% / 10%) }',
fixed: 'a { color: HSL(120deg 60% 70% / 10%) }',
message: messages.expected('120', '120deg'),
line: 1,
column: 16,
endLine: 1,
endColumn: 19,
},
{
code: 'a { color: hwb(180 0% 0%) }',
fixed: 'a { color: hwb(180deg 0% 0%) }',
message: messages.expected('180', '180deg'),
line: 1,
column: 16,
endLine: 1,
endColumn: 19,
},
{
code: 'a { color: lch(56.29% 19.86 10) }',
fixed: 'a { color: lch(56.29% 19.86 10deg) }',
message: messages.expected('10', '10deg'),
line: 1,
column: 29,
endLine: 1,
endColumn: 31,
},
{
code: 'a { color: hsl(/*comment*/120 60% 70%) }',
fixed: 'a { color: hsl(/*comment*/120deg 60% 70%) }',
message: messages.expected('120', '120deg'),
line: 1,
column: 27,
endLine: 1,
endColumn: 30,
},
{
code: stripIndent`
Expand All @@ -117,8 +127,20 @@ testRule({
}
`,
warnings: [
{ message: messages.expected('270', '270deg'), line: 4, column: 7 },
{ message: messages.expected('236.62', '236.62deg'), line: 5, column: 20 },
{
message: messages.expected('270', '270deg'),
line: 4,
column: 7,
endLine: 4,
endColumn: 10,
},
{
message: messages.expected('236.62', '236.62deg'),
line: 5,
column: 20,
endLine: 5,
endColumn: 26,
},
],
},
],
Expand Down Expand Up @@ -148,27 +170,35 @@ testRule({
message: messages.expected('120deg', '120'),
line: 1,
column: 16,
endLine: 1,
endColumn: 22,
},
{
code: 'a { color: HSL(120deg 60% 70% / 10%) }',
fixed: 'a { color: HSL(120 60% 70% / 10%) }',
message: messages.expected('120deg', '120'),
line: 1,
column: 16,
endLine: 1,
endColumn: 22,
},
{
code: 'a { color: HSLA(120DEG, 60%, 70%, 10%) }',
fixed: 'a { color: HSLA(120, 60%, 70%, 10%) }',
message: messages.expected('120DEG', '120'),
line: 1,
column: 17,
endLine: 1,
endColumn: 23,
},
{
code: 'a { color: lch(56.29% 19.86 10deg) }',
fixed: 'a { color: lch(56.29% 19.86 10) }',
message: messages.expected('10deg', '10'),
line: 1,
column: 29,
endLine: 1,
endColumn: 34,
},
{
code: stripIndent`
Expand All @@ -190,8 +220,20 @@ testRule({
}
`,
warnings: [
{ message: messages.expected('270deg', '270'), line: 4, column: 7 },
{ message: messages.expected('236.62deg', '236.62'), line: 5, column: 20 },
{
message: messages.expected('270deg', '270'),
line: 4,
column: 7,
endLine: 4,
endColumn: 13,
},
{
message: messages.expected('236.62deg', '236.62'),
line: 5,
column: 20,
endLine: 5,
endColumn: 29,
},
],
},
],
Expand Down Expand Up @@ -219,6 +261,8 @@ testRule({
message: messages.expected('0', '0deg'),
line: 1,
column: 9,
endLine: 1,
endColumn: 10,
},
],
});
Expand All @@ -245,6 +289,8 @@ testRule({
message: messages.expected('0deg', '0'),
line: 1,
column: 9,
endLine: 1,
endColumn: 13,
},
],
});