Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for longhand grid-column/row-* properties in value-keyword-case #4611

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Fix false positives for longhand grid-column/row-* properties in value-keyword-case #4611

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fb5cc5
Ignore area case (#4605)
fanich37 Feb 20, 2020
2243b44
Add more tests
fanich37 Feb 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add more tests
  • Loading branch information
@fanich37
fanich37 committed Feb 20, 2020
commit 2243b44e6bb420ad008b067593d5ee57d1349c41
11 changes: 11 additions & 0 deletions lib/rules/value-keyword-case/__tests__/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,13 @@ testRule(rule, {
line: 1,
column: 24,
},
{
code: 'a { GRID-COLUMN-START: SPAN camelCaseArea; }',
fixed: 'a { GRID-COLUMN-START: span camelCaseArea; }',
message: messages.expected('SPAN', 'span'),
line: 1,
column: 24,
},
],
});

Expand Down Expand Up @@ -1283,6 +1290,10 @@ testRule(rule, {
code: 'a { color: ThreeDShadow; }',
description: 'another system color',
},
{
code: 'a { GRID-COLUMN-START: SPAN camelCaseArea; }',
description: 'ignore property case',
},
],

reject: [
Expand Down