Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lint-staged config #4165

Merged
merged 1 commit into from
Jul 24, 2019
Merged

fix: lint-staged config #4165

merged 1 commit into from
Jul 24, 2019

Conversation

laysent
Copy link
Contributor

@laysent laysent commented Jul 23, 2019

Which issue, if any, is this issue related to?

Related discussion in #4163

Is there anything in the PR that needs further explanation?

Quoted from #4163:

I noticed that lint-staged changed the way how it's configured. From their document, they encourage to use ignore configuration of each linter. And since this file is already in .eslintignore and .prettierignore, I believe it's safe to remote corresponding line in lint-staged config.

hudochenkov
hudochenkov approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hudochenkov hudochenkov merged commit 2e3a438 into stylelint:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@ntwb ntwb ntwb approved these changes

@hudochenkov hudochenkov hudochenkov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laysent @hudochenkov @ntwb @alexander-akait