Docker registry #332
Docker registry #332
Conversation
.travis/setup-kubernetes.sh
Outdated
| sleep 5; | ||
| done | ||
|
|
||
| kubectl port-forward --namespace kube-system $POD 5000:5000 & |
There was a problem hiding this comment.
I was originally setting it like POD=$(kubectl get po -n kube-system | grep 'registry-[a-z0-9]' | awk '{print $1;}), which I was executing before the loop. The problem is that, initially when minikube starts it doesn't even know what pod resources are, so it went wrong before the loop was even entered.
See the interesting discussion about why kubectl doesn't handle readiness already: kubernetes/kubernetes#1899
There was a problem hiding this comment.
I'm really dumb but I still don't understand from where the $POD var comes from or where it's set :-)
There was a problem hiding this comment.
@ppatierno I updated the PR, so there is no $POD anymore
There was a problem hiding this comment.
@tombentley sorry, I remembered that after changes the comments are hidden by GitHub as "old" but I still saw our discussion with no changes on line 17. I can see the updated code in the "File changed" section ... sorry for asking twice :-)
There was a problem hiding this comment.
This looks good. But I guess you will also need to modify the system tests to use the images from the local registry? Or how is thaat dealt with?
Also, will there be any issues with the secure / insecure registries (which you need to configure before starting oc cluster up)?
TBH, I have no idea. The registry plugin doesn't seem to have any documentation. It had documentation, but that got removed, because apparently the YAML resources for it are documentation enough. So I don't know whether/how I need to take special steps to proxy the registry into the namespaces we use for testing, or whether than happens automagically.
From what I've read |
So my guess would be that you will need to prefix all images with |
|
Let's not do it like this. Life's too short. |
Type of change
Enhancement / new featureRefactoringDescription
This PR always pushed docker images to a local registry, which means the images used for the system test are the one produced by the build. If the system tests pass the images are pushed to docker hub.
Checklist
Please go through this checklist and make sure all applicable tasks have been done
Write testsCheck RBAC rights for Kubernetes / OpenShift rolesTry your changes from Pod inside your Kubernetes and OpenShift cluster, not just locallyReference relevant issue(s) and close them after mergingNote: I have not yet tested this on master.