Remove unused fields from @JsonPropertyOrder annotation
#10890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
scholzj
changed the title
@JsonPropertyOrder validation@JsonPropertyOrder annotation
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
Nov 30, 2024
OwenCorrigan76
pushed a commit
to OwenCorrigan76/strimzi-kafka-operator
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The
@JsonPropertyOrderannotation contains in some cases fields that do not exist - usually as a result of copy-paste errors and similar. This PR removes them.Originally, I wanted to add support for automatic validation similar to #9831. But it is not easily possible because of CRD versioning that might add or remove fields from different version. So I only cleaned the existing values.
Checklist