Skip to content
This repository has been archived by the owner on Nov 29, 2024. It is now read-only.

fix: adjust default producer/end-to-end latency buckets. #194

Merged
merged 1 commit into from
Jun 29, 2022
Merged

fix: adjust default producer/end-to-end latency buckets. #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

* Fixed replicas assignment taking rack configuration into account (#190)
* Use separate sarama clients for producer/consumer in order to reliably measure message latency (#188)
* Adjust default histogram bucket sizes (#194)

## 0.3.0

Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ The configuration file described in more detail the next section.
| `RECONCILE_INTERVAL_MS` | It defines how often the tool has to send and receive messages (in ms). | `30000` | |
| `CLIENT_ID` | The client id used for configuring producer and consumer. | `strimzi-canary-client` | |
| `CONSUMER_GROUP_ID` | Group id for the consumer group joined by the canary consumer. | `strimzi-canary-group` | |
| `PRODUCER_LATENCY_BUCKETS` | Buckets of the histogram related to the producer latency metric (in ms). | `100,200,400,800,1600` | |
| `ENDTOEND_LATENCY_BUCKETS` | Buckets of the histogram related to the end to end latency metric between producer and consumer (in ms). | `100,200,400,800,1600` | |
| `PRODUCER_LATENCY_BUCKETS` | Buckets of the histogram related to the producer latency metric (in ms). | `2,5,10,20,50,100,200,400` | |
| `ENDTOEND_LATENCY_BUCKETS` | Buckets of the histogram related to the end to end latency metric between producer and consumer (in ms). | `5,10,20,50,100,200,400,800` | |
| `EXPECTED_CLUSTER_SIZE` | Expected number of brokers in the Kafka cluster where the canary connects to. This parameter avoids that the tool runs more partitions reassignment of the topic while the Kafka cluster is starting up and the brokers are coming one by one. `-1` means "dynamic" reassignment as described above. When greater than 0, the canary waits for the Kafka cluster having the expected number of brokers running before creating the topic and assigning the partitions | `-1` | |
| `KAFKA_VERSION` | Version of the Kafka cluster | `3.1.0` | |
| `SARAMA_LOG_ENABLED` | Enables the Sarama client logging. | `false` | `saramaLogEnabled` |
Expand Down
4 changes: 2 additions & 2 deletions internal/config/canary_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ const (
ReconcileIntervalDefault = 30000
ClientIDDefault = "strimzi-canary-client"
ConsumerGroupIDDefault = "strimzi-canary-group"
ProducerLatencyBucketsDefault = "100,200,400,800,1600"
EndToEndLatencyBucketsDefault = "100,200,400,800,1600"
ProducerLatencyBucketsDefault = "2,5,10,20,50,100,200,400"
EndToEndLatencyBucketsDefault = "5,10,20,50,100,200,400,800"
ExpectedClusterSizeDefault = -1 // "dynamic" reassignment is enabled
KafkaVersionDefault = "3.1.0"
SaramaLogEnabledDefault = false
Expand Down