This repository has been archived by the owner on Nov 29, 2024. It is now read-only.
fix: adjust default producer/end-to-end latency buckets. #194
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-wall
force-pushed
the
adjust-bucket
branch
3 times, most recently
from
be67d56 to
d676e8d
Compare
following strimzi#188, the default producer/end-to-end histogram buckets used by ihe canary are no longer ideal with all of the obseverations falling into the first (<=100ms) bucket. This change introduces several smaller buckets and drops the largest ones. Signed-off-by: kwall <kwall@apache.org>
scholzj
approved these changes
Jun 29, 2022
melchiormoulin
pushed a commit
to melchiormoulin/strimzi-canary
that referenced
this pull request
Jun 29, 2022
following strimzi#188, the default producer/end-to-end histogram buckets used by ihe canary are no longer ideal with all of the obseverations falling into the first (<=100ms) bucket. This change introduces several smaller buckets and drops the largest ones. Signed-off-by: kwall <kwall@apache.org> Signed-off-by: Melchior Moulin <melchior.moulin@gmail.com>
melchiormoulin
pushed a commit
to melchiormoulin/strimzi-canary
that referenced
this pull request
Jul 3, 2022
following strimzi#188, the default producer/end-to-end histogram buckets used by ihe canary are no longer ideal with all of the obseverations falling into the first (<=100ms) bucket. This change introduces several smaller buckets and drops the largest ones. Signed-off-by: kwall <kwall@apache.org> Signed-off-by: Melchior Moulin <melchior.moulin@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #188, the default producer/end-to-end histogram buckets used by
ihe canary are no longer ideal with all of the obseverations falling into
the <=100ms bucket. This change introduces smaller buckets and drops the
largest ones.
Signed-off-by: kwall kwall@apache.org