Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow file type shortcuts in st.file_uploader #10068

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Allow file type shortcuts in st.file_uploader #10068

wants to merge 4 commits into from

Conversation

jrieke
Copy link
Collaborator

@jrieke jrieke commented Dec 22, 2024 •
edited
Loading

Describe your changes

Adds support for "image", "audio", "video", and "text" for the type parameter in st.file_uploader.

GitHub Issue Link (if applicable)

Testing Plan

  • Added a unit test for one of the types above as well as a combination with other file types.
  • Added to an existing e2e test, just to check that the display is correct. I don't think we need an extra e2e test for this as the functionality is fairly small and we also don't have e2e tests for different file extension combinations.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@jrieke jrieke marked this pull request as ready for review December 22, 2024 20:36
@jrieke jrieke changed the title [WIP] Allow file type shortcuts in st.file_uploader Allow file type shortcuts in st.file_uploader Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change:feature impact:users security-assessment-completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrieke @sfc-gh-jrieke