Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chat_test.py improvements with parameterized and clean ups #10054

Open
wants to merge 1 commit into
base: chat-input-with-file-uploder-mvp
Choose a base branch
from
Open

chat_test.py improvements with parameterized and clean ups #10054

wants to merge 1 commit into from

Conversation

sfc-gh-pchiu
Copy link
Contributor

Describe your changes

  • Consolidated tests with parameterized as it's already adopted for some test cases here
  • Remove placeholder whenever not validated with expected values

GitHub Issue Link (if applicable)

Testing Plan

  • pytests

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-pchiu sfc-gh-pchiu marked this pull request as ready for review December 20, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kajarenc kajarenc Awaiting requested review from kajarenc

Assignees
No one assigned
Labels
change:chore impact:internal security-assessment-completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-pchiu