Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Payload Generator improvements SO-232 #322

Merged
merged 14 commits into from
May 27, 2019
Merged

refactor: Payload Generator improvements SO-232 #322

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
750c11e
feat: make generator simple
XVincentX May 25, 2019
8e0fcaf
chore: undo stupid cluster stuff
XVincentX May 25, 2019
0a8117b
refactor: lower down generator responsibilities
XVincentX May 25, 2019
77ab99f
refactor: PayloadGenerator and put it in types
XVincentX May 25, 2019
1270970
chore: throw exception so that it's an application/problem-json
XVincentX May 25, 2019
7f41cf4
test: prefer assertions to snapshots
XVincentX May 25, 2019
a060f17
docs: fix path to the CLI script
XVincentX May 25, 2019
e83a3f6
docs: put the new simplified command
XVincentX May 25, 2019
7fca363
chore: do not publish on alpha we're doing stuff anyway there
XVincentX May 25, 2019
5b0c159
test: rename test describe title
XVincentX May 25, 2019
725e93e
Merge branch 'master' into feat/simple-generator
XVincentX May 27, 2019
319a9d2
Merge branch 'master' into feat/simple-generator
XVincentX May 27, 2019
9a8f91d
refactor: return empty string if the generated object is empty
XVincentX May 27, 2019
9a80dcb
chore: empty string
XVincentX May 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: fix path to the CLI script
  • Loading branch information
@XVincentX
XVincentX committed May 25, 2019
commit a060f1793db6ebdf73706c229eff84bbcc0b8fd6
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Yarn is a package manager for your code, similar to npm. While you can use npm t
2. Fork the [https://github.com/stoplightio/prism](https://github.com/stoplightio/prism) repo.
3. Git clone your fork (i.e. `git clone https://github.com/<your-username>/prism.git`) to your machine.
4. Run `yarn` to install dependencies and setup the project.
5. Because [oclif](https://oclif.io) does not respect the provided `tsconfig`, you can't use the bin directly, but we provide a script for that: `cd packages && yarn cli mock openapi.yaml`
5. Because [oclif](https://oclif.io) does not respect the provided `tsconfig`, you can't use the bin directly, but we provide a script for that: `cd packages/cli && yarn cli mock openapi.yaml`.
6. Run `git checkout -b [name_of_your_new_branch]` to create a new branch for your work. To help build nicer changelogs, we have a convention for branch names. Please start your branch with either `feature/{branch-name}`, `chore/{branch-name}`, or `fix/{branch-name}`. For example, if I was adding a CLI, I would make my branch name: `feature/add-cli`.
7. Make changes, write code and tests, etc. The fun stuff!
8. Run `yarn test` to test your changes.
Expand Down