fix variant WeActMiniH7xx, DevEBoxH7xx: ena peripheral pll clks #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 12, 2021 02:12
in previous commmit some clocks from PLL2, PLL3 are not distributed to some peripherals stm32duino#1552 originally to save some power. However, users using those pheriperials may mistake that it is not working this fix distributes the missed out PLL clocks to all pheripherals those clocks are at 80 Mhz
in previous commit (stm32duino#1552) some clocks from PLL2, PLL3 are not distributed to some peripherals originally to save some power. However, users using those pheriperials may mistake that it is not working this fix distributes the missed out PLL clocks to all pheripherals those clocks are at 80 Mhz
…no_Core_STM32 into variant_weactminih7xx
make the same fixes from stm32duino#1585 --- in previous commit (stm32duino#1552) some clocks from PLL2, PLL3 are not distributed to some peripherals originally to save some power. However, users using those pheriperials may mistake that it is not working this fix distributes the missed out PLL clocks to all pheripherals those clocks are at 80 Mhz ---
ag88
changed the title
fpistm
approved these changes
Dec 13, 2021
|
Thanks again @ag88 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in previous commit #1552 some clocks from PLL2, PLL3
are not distributed to some peripherals
originally to save some power. However, users using those
pheriperials may mistake that it is not working
this fix distributes the missed out PLL clocks to all pheripherals
those clocks are at 80 Mhz
Pull Request template
Please, Make sure that your PR is not a duplicate.
Search among the Pull request before creating one.
IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.
Thanks for submitting a pull request.
Please provide enough information so that others can review your pull request:
Summary
This PR fixes/implements the following bugs/features
distribute missed out PLL clocks to all peripherals (previously commented out)
bug fix
Validation
updated files in installed core and re-ran previous test in original commit.
#1552
compile, Arduino IDE 1.8.16:
Sketch uses 56148 bytes (2%) of program storage space. Maximum is 2097152 bytes.
Global variables use 4112 bytes (0%) of dynamic memory, leaving 520176 bytes for local variables. Maximum is 524288 bytes.
sample results:
led blinking per normal
Code formatting
Closing issues
Fixes #xxx