Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NumPy randomness for random walks, not Python #1666

Closed
wants to merge 3 commits into from
Closed

Use NumPy randomness for random walks, not Python #1666

wants to merge 3 commits into from

Conversation

huonw
Copy link
Member

@huonw huonw commented Jun 10, 2020 •
edited
Loading

Helpful for #462.

@codeclimate
Copy link

codeclimate bot commented Jun 10, 2020 •
edited
Loading

Code Climate has analyzed commit 3bf3330 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@huonw
Copy link
Member Author

huonw commented Jun 11, 2020

Hm, this seems to be a significant regression at the moment:

name median before median after
test_benchmark_uniformrandommetapathwalk 0.0115 0.0182
test_benchmark_uniformrandomwalk 0.0164 0.0306
test_benchmark_biasedrandomwalk 0.0273 0.0286
test_benchmark_bfs_walk 0.0283 0.0739
test_benchmark_bfs_walk (directed) 0.0841 0.249
test_benchmark_sampledheterogeneousbreadthfirstwalk 0.0853 0.564
test_benchmark_biasedweightedrandomwalk 0.590 0.631

@huonw
Copy link
Member Author

huonw commented Jun 11, 2020

Just going to do a small part of this in #1667.

@huonw huonw closed this Jun 11, 2020
@huonw huonw deleted the feature/numpy-random-state branch June 11, 2020 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@huonw