Skip to content

Commit

Permalink
Remove LGTM references and minor doc fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
oscargus committed Mar 5, 2023
1 parent 32b6ebb commit 73d73e6
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 25 deletions.
18 changes: 0 additions & 18 deletions .lgtm.yml

This file was deleted.

12 changes: 6 additions & 6 deletions doc/devel/coding_guide.rst
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ rules before submitting a pull request:

or your editor may provide integration with it. Note that Matplotlib
intentionally does not use the black_ auto-formatter (1__), in particular due
to its unability to understand the semantics of mathematical expressions
to its inability to understand the semantics of mathematical expressions
(2__, 3__).

.. _PEP8: https://www.python.org/dev/peps/pep-0008/
Expand Down Expand Up @@ -352,7 +352,7 @@ will run on all supported platforms and versions of Python.
- On the overview page *artifacts* are listed in the section *Related*.


* Codecov and LGTM are currently for information only. Their failure is not
* Codecov and CodeQL are currently for information only. Their failure is not
necessarily a blocker.

* tox_ is not used in the automated testing. It is supported for testing
Expand Down Expand Up @@ -461,27 +461,27 @@ should not be backported to this branch.
Automated backports
-------------------

We use meeseeksdev bot to automatically backport merges to the correct
We use MeeseeksDev bot to automatically backport merges to the correct
maintenance branch base on the milestone. To work properly the
milestone must be set before merging. If you have commit rights, the
bot can also be manually triggered after a merge by leaving a message
``@meeseeksdev backport to BRANCH`` on the PR. If there are conflicts
meeseekdevs will inform you that the backport needs to be done
MeeseeksDev will inform you that the backport needs to be done
manually.

The target branch is configured by putting ``on-merge: backport to
TARGETBRANCH`` in the milestone description on it's own line.

If the bot is not working as expected, please report issues to
`Meeseeksdev <https://github.com/MeeseeksBox/MeeseeksDev>`__.
`MeeseeksDev <https://github.com/MeeseeksBox/MeeseeksDev>`__.


.. _manual-backports:

Manual backports
----------------

When doing backports please copy the form used by meeseekdev,
When doing backports please copy the form used by MeeseeksDev,
``Backport PR #XXXX: TITLE OF PR``. If you need to manually resolve
conflicts make note of them and how you resolved them in the commit
message.
Expand Down
2 changes: 1 addition & 1 deletion lib/matplotlib/_api/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ def warn_external(message, category=None):
etc.).
"""
frame = sys._getframe()
for stacklevel in itertools.count(1): # lgtm[py/unused-loop-variable]
for stacklevel in itertools.count(1):
if frame is None:
# when called in embedded context may hit frame is None
break
Expand Down

0 comments on commit 73d73e6

Please sign in to comment.