Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update stats/base/dsempn native addon from C++ to C #4222

Merged
merged 2 commits into from
Dec 26, 2024
Merged

refactor: update stats/base/dsempn native addon from C++ to C #4222

merged 2 commits into from
Dec 26, 2024

Conversation

vivekmaurya001
Copy link
Contributor

Resolves None.

Description

  • adds C addons to stats/base/dsempn instead of c++ addons

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 25, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 25, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dsempn $\color{green}365/365$
$\color{green}+100.00\%$ 		$\color{green}14/14$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}365/365$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 26, 2024
@kgryte kgryte merged commit 1aa3235 into stdlib-js:develop Dec 26, 2024
11 checks passed
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 1, 2025
@vivekmaurya001 @Neerajpathak07
refactor: update stats/base/dsempn native addon from C++ to C
53447aa 
PR-URL: stdlib-js#4222
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivekmaurya001 @stdlib-bot @kgryte