Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for stats/base/dists/gamma/stdev #4128

Merged
merged 3 commits into from
Dec 21, 2024
Merged

feat: add C implementation for stats/base/dists/gamma/stdev #4128

merged 3 commits into from
Dec 21, 2024

Conversation

0PrashantYadav0
Copy link
Contributor

@0PrashantYadav0 0PrashantYadav0 commented Dec 21, 2024 •
edited
Loading

Resolves #3628

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for @stdlib/stats/base/dists/gamma/stdev along with relevant tests, benchmarks and examples

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 21, 2024
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 21, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/gamma/stdev $\color{green}190/190$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}190/190$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@0PrashantYadav0
Copy link
Contributor Author

@Planeshifter Please review this PR

@Planeshifter
docs: replace stdev with standard deviation in C comments
cf8eaf4 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small edit, otherwise this one looks well to me. Let's get it in!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 21, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 21, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/gamma/stdev`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4128
Closes: https://github.com/stdlib-js/stdlib/issues/3628

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 83aeb94 into stdlib-js:develop Dec 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/gamma/stdev
3 participants
@0PrashantYadav0 @stdlib-bot @Planeshifter