Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for stats/base/dists/logistic/mode #4029

Merged
merged 3 commits into from
Dec 19, 2024
Merged

feat: add C implementation for stats/base/dists/logistic/mode #4029

merged 3 commits into from
Dec 19, 2024

Conversation

0PrashantYadav0
Copy link
Contributor

Resolves #3741

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/logistic/mode along with relevant tests, docs, examples and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 18, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 18, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/logistic/mode $\color{green}175/175$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}175/175$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Planeshifter
Planeshifter approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @0PrashantYadav0!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 19, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 19, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/logistic/mode`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4029
Closes: https://github.com/stdlib-js/stdlib/issues/3741

Co-authored-by: JoyBoy <144602492+0PrashantYadav0@users.noreply.github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 7cff91f into stdlib-js:develop Dec 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/logistic/mode
3 participants
@0PrashantYadav0 @stdlib-bot @Planeshifter