Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demux preferred languages but don't include them does not demux subs in 2.42.0 #1471

Closed
wrzlpete opened this issue Sep 7, 2024 · 5 comments

Comments

@wrzlpete
Copy link

wrzlpete commented Sep 7, 2024

Describe the bug
Project Options -> Subtitles -> Demux preferred languages but don't include them

  • this setting does not demux the preferred langauges (= create the subtitle files in the temp folder) anymore since 2.42.0

Expected behavior
Demuxing should work the same as in 2.41.x

How to reproduce the issue
Activate Project Options -> Subtitles -> Demux preferred languages but don't include them
Open a file that includes subtitles of the preferred languages

Provide information
The temp folder for the file does not include any subtitle files. First I thought this was related to some kind of bad import of settings (which I didn't actually do really), but I when I made sure and recreated all relevant settings from complete scracth with 2.42.0 the issue remained.

@Dendraspis
Copy link
Collaborator

Dendraspis commented Sep 7, 2024

The only problem that I can confirm is that too many subtitles are demuxed. 🥴

Tell me more about your source file....

@staxrip staxrip deleted a comment from Andrasolin Sep 7, 2024
@staxrip staxrip deleted a comment from Andrasolin Sep 7, 2024
@wrzlpete
Copy link
Author

wrzlpete commented Sep 7, 2024

I'm not talking about the subs inside the container (menu), but the extracted subtitle files that had been inside the default temp folder before the change to 2.42.0.

The reason for this is that I use a script to hardcode the demuxed subtitle files into the video, and this does not work anymore since there are no subtitle files in the temp folder when using "Demux preferred languages but don't include them".

The files are being created when using "Demux preferred languages and include them", but I do not want to include them when hardcoding the subs into the video stream.

I don't think the source file matters much since the options do not seem handle demuxing consistently, but for reference, the streams of the source file are as shown on the screenshot of a mkvmerge output:

sample

@wrzlpete wrzlpete changed the title Demux preferred languages but don't onclude them does not demux subs in 2.42.0 Demux preferred languages but don't include them does not demux subs in 2.42.0 Sep 7, 2024
@Dendraspis
Copy link
Collaborator

Okay, got you. I will check that....

@Dendraspis
Copy link
Collaborator

Dendraspis commented Sep 8, 2024

Please try v2.42.1-RC2 and tell me, if that fixes your issues:

v2.42.1 is out and should fix the issue. Please re-open this issues if not...

@wrzlpete
Copy link
Author

wrzlpete commented Sep 8, 2024

Yep, everything now works as it should. Cheers! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants