We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think that this sounds really nice:
https://eslint.org/blog/2022/07/interesting-bugs-caught-by-no-constant-binary-expression/
Ecosystem impact:
fastify/fastify
test/internals/reply.test.js:175
reply.serializer((x) => (customSerializerCalled = true) && JSON.stringify(x))
test/internals/reply.test.js:184
const context = { [kReplySerializerDefault]: (x) => (customSerializerCalled = true) && JSON.stringify(x) }
The only affected code is the two lines above, where Fastify is using a little trick to do two things on one line. It could be replaced with e.g.
reply.serializer((x) => { customSerializerCalled = true; return JSON.stringify(x) })
or
reply.serializer((x) => { customSerializerCalled = true return JSON.stringify(x) })
(ping @mcollina, since your repo is the affected one)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I think that this sounds really nice:
https://eslint.org/blog/2022/07/interesting-bugs-caught-by-no-constant-binary-expression/
Ecosystem impact:
fastify/fastify
:test/internals/reply.test.js:175
:reply.serializer((x) => (customSerializerCalled = true) && JSON.stringify(x))
test/internals/reply.test.js:184
:const context = { [kReplySerializerDefault]: (x) => (customSerializerCalled = true) && JSON.stringify(x) }
The only affected code is the two lines above, where Fastify is using a little trick to do two things on one line. It could be replaced with e.g.
or
(ping @mcollina, since your repo is the affected one)
The text was updated successfully, but these errors were encountered: