Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle module name resolution in KSP #947

Merged
merged 5 commits into from
Apr 5, 2024
Merged

Gracefully handle module name resolution in KSP #947

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
561c001
Gracefully handle module name resolution in KSP
ZacSweers Apr 3, 2024
f95f9a6
Don't generate if mangled without available mangling
ZacSweers Apr 3, 2024
0e15a90
Merge branch 'main' into z/betterModuleName
ZacSweers Apr 3, 2024
ac35388
Update message
ZacSweers Apr 4, 2024
8611e7d
Merge branch 'main' into z/betterModuleName
ZacSweers Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update message
  • Loading branch information
@ZacSweers
ZacSweers committed Apr 4, 2024
commit ac3538846beab65e1af23f75940d965d1d64eab1
5 changes: 2 additions & 3 deletions .../src/main/java/com/squareup/anvil/compiler/codegen/dagger/ProvidesMethodFactoryCodeGen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ internal object ProvidesMethodFactoryCodeGen : AnvilApplicabilityChecker {
val containingFile = clazz.containingFile!!
// TODO we need a public API for this in KSP
// https://github.com/google/ksp/issues/1621
// https://youtrack.jetbrains.com/issue/KT-66713
var supportsMangledNames: Boolean = false
var mangledNameSuffix: String = ""
try {
Expand All @@ -132,8 +131,8 @@ internal object ProvidesMethodFactoryCodeGen : AnvilApplicabilityChecker {
.forEach { declaration ->
if (declaration.isMangled && !supportsMangledNames) {
env.logger.error(
"Could not determine mangled name suffix. Please consider making this public " +
"and/or starring this issue: https://youtrack.jetbrains.com/issue/KT-66713.",
"Could not determine mangled name suffix. This will be fixed in a future " +
"release, but a temporary workaround is to make this declaration public.",
declaration.reportableNode as? KSNode,
)
} else {
Expand Down