-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.11.2 - outstanding pieces #1773
Comments
Thanks, just added those. 😄 |
Hang on... #1733 looks like it was merged in time for 3.11.1. Yep, it's in the 3.11.1 release notes, so just removed it from our list in this one. 😄 |
Oh you're right! 😄 But there's still e52f205 which breaks the grammar parser in similar ways. |
Yeah, that's why I added 1a59c8c. That's the |
Yep, it is 😄 |
Thanks. 😄 |
#1772 should be fixed in 0adb0af and I think it could be brought to the release branch. @MKleusberg maybe you could take a look to the solution, just in case you come up with a better approach or still pending gaps. I was surprised by the fact that |
It might be ready for release, but it contains a lot of changes. Maybe the cherry-picking raises conflicts. |
Yeah, I haven't checked yet. Was more thinking that even if it doesn't raise conflicts... not sure that we've really had many people testing it yet. Kind of nervous to put it in, this far along the stabilising of a major release... ... on the other hand, a lot of people do seem to want a dark theme available. Thoughts? 😄 |
@mgrojo I think your commits looks reasonable. I have no better idea either 😄 But I don't think it's a bug in Qt. In the docs they say
which to me sounds like the size parameter doesn't determine the length of the input but only how much of the input should be converted. So while I think what we want would make more sense, this doesn't sound like a bug in Qt. |
@MKleusberg I guess they'd claim is working as expecte, but it is a bit inconsistent, because some codecs will stop at the first zero and others not, because that is a valid encoding pattern, like in UTF-16. In fact, I've checked that the same behaviour is in the ISO-8859-1 and I guess in all of the ISO-8859 encodings. if((encoding.isEmpty() || encoding.startsWith("ISO-8859")) && data.contains('\0'))
return false; Probably a lot more encodings don't use embedded zeros, but I think we can leave it as above, unless someone comes up with a better idea. |
It looks like #1772 (comment) still has some fine tuning to do. I'll move the release date for 3.11.2 back a week, so there's some breathing space to investigate, etc. I'm not personally ready to make the release yet anyway, as I'm focusing on getting a first working version of |
@MKleusberg The patch for #1758 isn't in the |
@justinclift No worries, I have just cherry-picked it 😄 Thanks for pointing this one out by the way! @mgrojo I completely agree with everything you said 😄 At some point it probably makes sense to change the entire binary detection code anyway, so for now this is hopefully good enough. |
In theory, we should be releasing 3.11.2 tomorrow or so.
I'm not sure on the status for #1772. It kind of sounds like the patch there introduced incorrect character counts, and I'm not sure what's going on with that. 😉 |
The incorrect character counts (in fact, stripping of CR characters), predates #1772 and it's even present in v3.11.x. The solution (#1793) is too disruptive to be added, because it involves replacing the Qt widget by the QScintilla one. I've added the two commits fixing #1772 to the v3.11.x branch. |
Thanks @mgrojo. Sounds like we've done the best we can with that for the I'll build our macOS & Windows release binaries for 3.11.2 today or tonight, so we're good to release when @MKleusberg has time to sign the Windows bits. 😄 My focus stuff (the dio command line utility) is taking a lot longer than I was hoping for. The first pass of it was finished last night, but it really needs unit tests added to catch at least the straight forward bugs. And there will be bugs. 😉 |
@justinclift Did you have the time to build the binaries yet? I could easily sign them this week. But any later day would work too 😄 |
Not yet. Super focused on getting the the unit tests for dio finished (should be done tonight) so it's releasable. There are ~30 pieces of dio to write tests for, and I'm on the last one now (as of last night). I'm thinking the binary building will probably be friday. 😄 |
Binary building is going to be tomorrow instead of today. I've just now finished the |
@justinclift - @mgrojo completed a fix for #1709 on Feb 23. Can you please advise if that is getting picked up on the 3.11.2 release? I don't see it in the list above. |
I've no objections to including it, if @mgrojo feels it's a decent idea. 😄 |
Just in case it helps, I've regenerated the .ts files in the v3.11.x branch. It still has the "unfinished" strings, so should I apply your PR to this as well? https://github.com/sqlitebrowser/sqlitebrowser/blob/v3.11.x/src/translations/sqlb_it.ts |
Ouch! You're right, I've done the changes from the "master" branch. I haven't checked the v3.11x branch, anyway if the strings are a subset of master, you can pick them from there :) Thanks. |
Thanks @GortiZ6. 😄 I'll get that done later one today, before creating the new 3.11.2 release builds. 😄 |
Done in d389a62. 😄 |
Started getting this done, but need sleep. Will pick this up in the morning instead. |
Ok, give me a minute 😃 |
And it's done 😄 They are all signed and added to the release draft. |
Excellent, thanks. I'm still updating bits on the mac build server... it's nearly done. 😄 |
Awesome 😄 So we might get a new release today if things go well 🍾 |
I'll get the README + website updated (etc) over the next few hours. 😄 |
Now unpublished. Guess who forgot to update the version string in our source before generating binaries... yep me. Dammit. Ok, getting that done now. *sigh* |
Just added the (fixed) macOS .dmg to the draft release. Feel free to hit the publish button when the new windows binaries are signed (etc). 😄 |
Hi Manuel,
I'll have a look this week if possible.
best regards
Michel
|
@mvt91 Ahhh, we've already created the release binaries, so maybe next time instead? 😉 |
Heh heh, no problem! I have just signed the new binaries and will publish the updated release in a second. |
Thanks. I'll get the rest of the bits done (eg download cluster, website post, etc). 😄 |
@deepsidhu1313 @lbartoletti We've just released DB4S 3.11.2, if you're interested in updating your packaging bits. 😄 |
Hmmm, just realised we should be including an AppImage with this release. Um... @deepsidhu1313, any interest in building it and adding it directly to the 3.11.2 GitHub Release? https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.11.2 |
Yeah sure.
|
Thanks @deepsidhu1313. When you've added it to the release info, please let me know. I'll then copy it to our download cluster for that to be the main download source for it, so we can count downloads ourselves instead of having to rely on stats from GitHub. 😄 |
I think everything I needed to do for the release is done now, and all of the appropriate people notified. Time to get some sleep. 😄 |
Hi Justin,
No problems.
I found the nightly test data. I'll can check next time some functionalities I don't know about :)
Time is going to much quickly for me. New decade this month :)
Best regards
Michel
|
Sorry guys, just busy with Job project. Sending product for client review.
Will look into releasing packages today. Apologies for the delay.
…On Thu, Apr 4, 2019, 5:24 AM mvt91 ***@***.***> wrote:
Hi Justin,
No problems.
I found the nightly test data. I'll can check next time some
functionalities I don't know about :)
Time is going to much quickly for me. New decade this month :)
Best regards
Michel
----- Mail d'origine -----
De: Justin Clift ***@***.***>
À: sqlitebrowser/sqlitebrowser ***@***.***>
Cc: mvt91 ***@***.***>, Mention ***@***.***>
Envoyé: Wed, 03 Apr 2019 17:47:04 +0200 (CEST)
Objet: Re: [sqlitebrowser/sqlitebrowser] 3.11.2 - outstanding pieces
(#1773)
@mvt91 Ahhh, we've already created the release binaries, so maybe next
time instead? 😉
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#1773 (comment)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1773 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVA8uQcdNPrLcHN9eJ-K3AILVzsflCIks5vddLZgaJpZM4bYda6>
.
|
No worries @deepsidhu1313, Real Life takes priority. 😄 |
Closing this issue, as 3.11.2 is out and nothing seems to have broken (badly). We can keep updating this with info if needed, and/or open new issues where appropriate. 😄 |
The text was updated successfully, but these errors were encountered: