Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac Keyboard Shortcut for Replace (CTRL+H) on 3.11.1 #1749

Open
rkashden opened this issue Feb 19, 2019 · 4 comments
Open

Mac Keyboard Shortcut for Replace (CTRL+H) on 3.11.1 #1749

rkashden opened this issue Feb 19, 2019 · 4 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs. osx

Comments

@rkashden
Copy link

Details for the issue

What did you do?

Pressed CTRL+H in the sql query edit screen

What did you expect to see?

The find/replace dialog popup.

What did you see instead?

The last character of the query was deleted.

Useful extra information

DB4S v3.11.1 [built for x86_64-little_endian-lp64] on macOS 10.14 (darwin/18.2.0) [x86_64]
using SQLCipher Version 4.0.1 community (based on SQLite 3.26.0)
and Qt 5.11.3

@justinclift justinclift added bug Confirmed bugs or reports that are very likely to be bugs. osx labels Feb 19, 2019
@justinclift
Copy link
Member

Thanks @rkashden. Sounds like a macOS specific key combination thing, that we might need to figure out an alternative combination for.

If you try Alt+H and or Cmd+H, do either of them get the find/replace dialog to pop up?

@rkashden
Copy link
Author

Hi, I tried both Alt+H and Cmd+H but neither will show the dialog. The "Cmd+H" is a standard Mac keyboard shortcut for "hide application", so I'd probably stay clear of that. "Alt+H" inserts a non-alphanumeric character into the query window.

Please let me know if there's anything I can do to help.

@mgrojo
Copy link
Member

mgrojo commented Feb 19, 2019

The Scintilla library eclipses any shortcut that we could have set at Qt level. We've already seen that for "Ctrl+/" that we had to unbind at the Scintilla level in order to use it for commenting selection. The case is that I don't see any explicit mapping of Ctrl+H to delete character in the Scintilla code. @justinclift is the version that we include in the repository the one used for compiling in macOS?

It might be related to Backspace being Ctrl+H in terminals. But I don't think Scintilla is emulating a terminal in any way.

@justinclift
Copy link
Member

@justinclift is the version that we include in the repository the one used for compiling in macOS?

Yep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs. osx
Projects
None yet
Development

No branches or pull requests

3 participants