Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've run into the issue described here and partially fixed here. On my project, it seems like Redshift will not only quote the table name, but also the schema name in some instances, which breaks more stuff than the initial fix addresses.
By unquoting the schema and table names in a couple of extra places, I was able to get my project to autogenerate migrations for the offending schemas without issues. The problems mostly occurred around foreign key resolving, as far as I can tell.
These changes worked for my project, but I'm unfamiliar with inner workings of sqlalchemy dialects, so if there is a better place for unquoting the names please let me know. I've also struggled with coming up with unit tests for these changes, so any advise would be much appreciated.