Fix Insert/Update/Delete CTEs #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
reviewed
Jan 26, 2017
| @@ -56,3 +56,6 @@ docs/_build/ | |||
|
|
|||
| # PyBuilder | |||
| target/ | |||
|
|
|||
| # IntelliJ | |||
|
@wrmsr are you looking to finish this PR at some point? Just ran into the same nasty issue. |
|
I too just ran into this issue. I filed a new issue as there now seems to be a flag in the base Dialect class that toggles the insert/cte order, see issue #154 . |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this patch fixes the fact that redshift wants cte's on inserts after the insert (which seems to conflict with the pg grammar but whatever amzn). This effectively fixes the behavior noted here. Notably this changed in sa 1.1.0 from the cte's simply being absent (as is the case in the version depped by this lib) to them being in the wrong position (as in the latest version of sa for which I originally authored this patch). In both cases however this patch appears to function correctly.
Todos