-
Notifications
You must be signed in to change notification settings - Fork 372
Adding support for EventBridge #525
base: main
Are you sure you want to change the base?
Conversation
@jmnarloch Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@jmnarloch Thank you for signing the Contributor License Agreement! |
As a side question, is there any other package that would require to be changed to add full support for AWS Events? How about Spring Cloud Streams? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've added small comments and then we can merge this.
f5c583e
to
c296334
Compare
@marcingrzejszczak Thanks for reviewing the change, I address the comment and pushed updated revision. |
@marcingrzejszczak any other feedback? |
@spencergibb would you mind taking a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the @Enable
annotation I don't think I'm qualified to review the messaging stuff. Maybe @artembilan or @garyrussell has some time to look?
@Target(ElementType.TYPE) | ||
@Retention(RetentionPolicy.RUNTIME) | ||
@Import({ EventBridgeConfiguration.class }) | ||
public @interface EnableEventBridge { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spring Cloud has moved away from @Enable
annotations for the most part. Seems like this could just be auto-configuration with @ConditionalOnClass
guards
Summary: Adds support for AWS EventBridge to the
spring-cloud-aws-messaging
. EventBridge is service launched in August 2019. EventBridge allows to decouple the service applications by publishing events, to which application/services can subscribe to.To some degree the implementation is very similar to SNS integration, currently EventBridge allows only publishing the events. Consuming them is possible through AWS Lambda.
Compared to SNS though there are couple differences:
source
anddetail-type
.Reference: