Fix Option Value promo rule and Create Line Items promo action #12196
+124
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mad-eel
commented
Oct 29, 2024
| @@ -147,6 +149,15 @@ def options=(options = {}) | |||
| assign_attributes opts | |||
| end | |||
|
|
|||
| def from_promotion | |||
There was a problem hiding this comment.
This is useful when we want to display proper info on eg. the storefront - instead of price, quantity picker, etc.
mad-eel
commented
Oct 29, 2024
| order: order, | ||
| variant: item.variant, | ||
| quantity: item.quantity - current_quantity, | ||
| options: { validate_only_quantity: true } |
There was a problem hiding this comment.
I added the possibility here to add a free item to the cart when it's in draft state
mad-eel
force-pushed
the
fix/promos-rule-actions
branch
from
ec5b65a to
acf47fa
Compare
mad-eel
force-pushed
the
fix/promos-rule-actions
branch
from
acf47fa to
5e9c7f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Spree::LineItem#from_promotionto determine if the item was added through the promotionSpree::Promotion::Rules::OptionValuepromo rule