Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Halyard uses endpoint removed in Kubernetes 1.10 #2728

Closed
will-gtv opened this issue May 1, 2018 · 2 comments
Closed

Halyard uses endpoint removed in Kubernetes 1.10 #2728

will-gtv opened this issue May 1, 2018 · 2 comments
Labels
component/halyard

Comments

@will-gtv
Copy link

will-gtv commented May 1, 2018 •
edited
Loading

Issue Summary:

hal deploy apply uses the old style proxy path for kubernetes which was removed in v1.10

Cloud Provider(s):

  • Kubernetes

Environment:

Spinnaker running on and deploying to a cluster upgraded to 1.10 in AWS.

Feature Area:

Halyard: hal deploy apply

Description:

When deploying services to kubernetes halyard calls http://localhost:41573/api/v1/proxy/namespaces/spinnaker/services/spin-orca-bootstrap:8083/orchestrate which gives a 404 in kubernetes 1.10 as the base /api/v1/proxy path has been removed in favour of /api/v1/namespaces/{namespace}/{type}/{object}/proxy. This shows up as ERROR Unexpected exception: retrofit.RetrofitError: 404 Not Found and all services failing to deploy.

Steps to Reproduce:

  • Deploy or upgrade to kubernetes 1.10
  • Configure halyard to deploy to kubernetes
  • Run hal deploy apply

Additional Details:

Kubernetes PR removing the path used: kubernetes/kubernetes#59884

/var/log/spinnaker/halyard/halyard.log:

---> HTTP POST http://localhost:41573/api/v1/proxy/namespaces/spinnaker/services/spin-orca-bootstrap:8083/orchestrate
<--- HTTP 404 http://localhost:49117/api/v1/proxy/namespaces/spinnaker/services/spin-orca-bootstrap:8083/orchestrate (299ms)
2018-05-01 14:57:57.925 ERROR 32208 --- [     Thread-156] c.n.s.halyard.core.DaemonResponse        : Unknown exception encountered: 

retrofit.RetrofitError: 404 Not Found
        at retrofit.RetrofitError.httpError(RetrofitError.java:40) ~[retrofit-1.9.0.jar:na]
        at retrofit.RestAdapter$RestHandler.invokeRequest(RestAdapter.java:388) ~[retrofit-1.9.0.jar:na]
        at retrofit.RestAdapter$RestHandler.invoke(RestAdapter.java:240) ~[retrofit-1.9.0.jar:na]
        at com.sun.proxy.$Proxy132.orchestrate(Unknown Source) ~[na:na]
        at com.netflix.spinnaker.halyard.deploy.deployment.v1.DistributedDeployer.lambda$deployServiceWithOrca$8(DistributedDeployer.java:281) ~[halyard-deploy-1.1.0-20180425120405.jar:1.1.0-20180425120405]
        at com.netflix.spinnaker.halyard.deploy.deployment.v1.OrcaRunner.getTaskEndpoint(OrcaRunner.java:64) ~[halyard-deploy-1.1.0-20180425120405.jar:1.1.0-20180425120405]
        at com.netflix.spinnaker.halyard.deploy.deployment.v1.OrcaRunner.monitorPipeline(OrcaRunner.java:53) ~[halyard-deploy-1.1.0-20180425120405.jar:1.1.0-20180425120405]
        at com.netflix.spinnaker.halyard.deploy.deployment.v1.DistributedDeployer.deployServiceWithOrca(DistributedDeployer.java:282) ~[halyard-deploy-1.1.0-20180425120405.jar:1.1.0-20180425120405]
        at com.netflix.spinnaker.halyard.deploy.deployment.v1.DistributedDeployer.lambda$deploy$4(DistributedDeployer.java:213) ~[halyard-deploy-1.1.0-20180425120405.jar:1.1.0-20180425120405]
        at com.netflix.spinnaker.halyard.core.DaemonResponse$StaticRequestBuilder.build(DaemonResponse.java:127) ~[halyard-core-1.1.0-20180425120405.jar:1.1.0-20180425120405]
        at com.netflix.spinnaker.halyard.core.tasks.v1.TaskRepository.lambda$submitTask$1(TaskRepository.java:48) ~[halyard-core-1.1.0-20180425120405.jar:1.1.0-20180425120405]
        at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_162]

2018-05-01 14:57:57.925  WARN 32208 --- [     Thread-156] c.n.s.h.core.tasks.v1.TaskRepository     : Task [Deploy spin-deck] (f06a9258-6365-4d85-9d28-134ff09a86d6) - RUNNING failed with unexpected reason:
@lwander
Copy link
Member

lwander commented May 1, 2018

Should hopefully be as easy as updating the client library... https://github.com/fabric8io/kubernetes-client

will have to see

@kangwoo kangwoo mentioned this issue May 4, 2018
Merged
@ezimanyi
Copy link
Contributor

Addressed by PR linked above; fix included in Halyard 1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/halyard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ezimanyi @lwander @will-gtv