Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag Value output sorts some elements by SPDXID #206

Open
kzantow opened this issue Apr 27, 2023 · 1 comment
Open

Tag Value output sorts some elements by SPDXID #206

kzantow opened this issue Apr 27, 2023 · 1 comment

Comments

@kzantow
Copy link
Collaborator

kzantow commented Apr 27, 2023

When outputting Tag Value format, some elements like Files are being sorted before being output, and these seem to be sorted by SPDXID. This causes a bit of a stability issue that a subsequent run, if an SPDXID is not stable (e.g. someone generating a UUID or other type of hashing function), elements are reordered in unexpected ways.

I believe these elements should be sorted by some type of primary field (like a file name) and subsequently by SPDXID for duplicates.
@lumjjb
Copy link
Collaborator

lumjjb commented Apr 27, 2023

hmmm, order shouldn't matter in spec, so this would be more for convenience.. but yea i think if its more convenient to have a bit more consistency, dont see why not... however, this could lead to the output document not being reproducible (unless we take the ordering of names followed by SPDX ID if tied).

Besides the reproducibility, i have no issue with changing the order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kzantow @lumjjb