Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store license diff screenshot in database instead of uploading to github #218

Open
rtgdk opened this issue Aug 26, 2020 · 5 comments
Open

Store license diff screenshot in database instead of uploading to github #218

rtgdk opened this issue Aug 26, 2020 · 5 comments
Labels
good-first-issue Begineer issue gsoc Submit New License Issues related to the submit new license feature

Comments

@rtgdk
Copy link
Collaborator

rtgdk commented Aug 26, 2020

Currently we upload the diff of the license text on a separate diff repo (see DIFF_REPO_WITH_OWNER in settings.py). Instead of uploading to github, we can directly save the static file in the database. Django provides BinaryField to store raw binary data.

Some links, articles and group conversations.

  1. https://docs.djangoproject.com/en/3.1/ref/models/fields/#binaryfield
  2. https://groups.google.com/g/django-developers/c/5wRAbViLf1s
  3. https://wiki.postgresql.org/wiki/BinaryFilesInDB
@rtgdk rtgdk mentioned this issue Aug 26, 2020
Merged
@rtgdk rtgdk added good-first-issue Begineer issue gsoc labels Mar 21, 2021
@Ugtan
Copy link
Collaborator

Ugtan commented Jul 22, 2021

@rtgdk I don't think so it would be a good idea to use binaryField, I know the number of screenshots would be less but considering the warning on the Django official docs reference here. Also, the StackOverflow answer says that we might face some issues related to caching if we use binaryField reference. What are your thoughts about this?

@rtgdk
Copy link
Collaborator Author

rtgdk commented Aug 7, 2021

@Ugtan I think we should be good. Having extra columns in sql is fine. We don't expect to have a lot of these. Keeping a separate repo is quite a hassle to setup.

@Ugtan
Copy link
Collaborator

Ugtan commented Aug 8, 2021

@rtgdk Okay perfect.

@jlovejoy jlovejoy added the Submit New License Issues related to the submit new license feature label Jun 21, 2023
@jlovejoy
Copy link
Member

@rtgdk - was this resolved and can close issue?

@goneall
Copy link
Member

goneall commented Jun 24, 2023

@jlovejoy - not resolved yet - a good idea, but probably lower priority to other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Begineer issue gsoc Submit New License Issues related to the submit new license feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@goneall @jlovejoy @rtgdk @Ugtan