Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModelCopyManager consumes an ever increasing amount of memory over time #260

Open
goneall opened this issue Nov 9, 2024 · 1 comment
Open

ModelCopyManager consumes an ever increasing amount of memory over time #260

goneall opened this issue Nov 9, 2024 · 1 comment

Comments

@goneall
Copy link
Member

goneall commented Nov 9, 2024

As reported by #258 - the ModelCopyManager consumes an ever increasing amount of memory due to caching the copied ID's.

One possible solution would be to implement some form of garbage collection. When a ModelStore is destroyed, it could call back to the ModelCopyManager to remove all the associated references from the cache.

Note that this approach may have some CPU performance implications due to having to lock the cache during the operation.
@martin-bpw
Copy link

Yes this would also be an option, I was already considering doing something like this (but using reflection to access the state).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goneall @martin-bpw