(re-open) Fix directory detection for Windows directory symlinks #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apps running on Windows that have used
php storage:linkwould see all their exports fail due to/public/storagebeing treated as a (non-link) file instead of a directory.Stepping into a debugger revealed that
SplFileInfo::isDir(),SplFileInfo::isFile()andSplFileInfo::isLink()all returned false on that specific entry.However,
SplFileInfo::getRealPath()does yield the correct directory path (i.e. the one the symlink points to).As such, this PR simply makes directory detection portable on all OS that could suffer from this specific issue without hindering the process for other types of files.