fix(jruby): XHTML formatting of non-container element closing tags #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JRuby code for SaveContextVisitor is brittle and clearly buggy (since this bug exists for fragment nodes but not fragments or document nodes?), but this seems like an easy fix. Fixes #2355
|
Note the BSD build failure is underlying github actions infrastructure flakiness; and the windows 2.5 builds failing is unrelated (see #2354). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Fixes #2355
The JRuby code for SaveContextVisitor is brittle and clearly
buggy (since this bug exists for fragment nodes but not fragments or
document nodes?), but this seems like an easy fix.
Have you included adequate test coverage?
Yes. Though I fear we still don't have enough coverage on JRuby formatting.
Does this change affect the behavior of either the C or the Java implementations?
This brings the JRuby implementation in line with the C implementation and the XHTML spec.