Update html5 tests #2281
Merged
Update html5 tests #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent tests to html5lib extended the format for the tree construction tests. Also add some additional output for some assertions to aid in fixing tests.
The HTML spec changed to handle `</p>` and `</br>` in foreign context the same way `<p>` and `<br>` are. The fragment case is handled identically to the nonfragment case now.
Update to the latest version of html5lib-tests. The spec currently has a [bug](whatwg/html#6808) so the parser does not conform to the spec, but it does match Safari, Firefox, Chrome, and the html5lib-tests tests.
|
@craigbarnes You'll probably want the changes to gumbo in this PR. The spec changed in its handling of some misformed HTML. |
|
@stevecheckoway Just as an FYI in case it ended up being not-obvious, here are the gumbo-related test runs for this PR:
And the html5lib tests run in every CI job (see nokogiri/.github/workflows/ci.yml Lines 84 to 86 in 5e65d56 Everything is green! Go ahead and hit that merge button when you're ready. |
flavorjones
approved these changes
Jun 28, 2021
33 tasks
|
I don't believe I have access to merge. |
|
@stevecheckoway Thanks for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
html5lib-tests has updated since I forked it to fix a bunch of errors. Some of the updates include new tests to test functionality that changed in the spec. This updates the code to parse the new tests, updates the submodule to include my fixes to the latest version of html5lib-tests, and updates the gumbo parser to accommodate the spec changes.
The new tests were mentioned in #2204 (comment).
Have you included adequate test coverage?
Yes. The changes to the parser include parser-specific tests and the update to html5lib-tests includes end-to-end tests to test the behavior.
Does this change affect the behavior of either the C or the Java implementations?
This only affects the C implementation as the gumbo parser isn't use for the Java implementation.