style: Refactor code to make things cleaner

sparckles · sansyrox · Feb 19, 2023 · Feb 11, 2023 · Feb 11, 2023 · Feb 11, 2023
commit 4b5dd5be1451706935aedc94cfe8d89bdad12d3c
diff --git a/integration_tests/base_routes.py b/integration_tests/base_routes.py
@@ -487,7 +487,7 @@ async def async_raise():
 # ===== Views =====
 
 
-@app.view("/sync_decorator_view")
+@app.view("/sync/view/decorator")
 def sync_decorator_view():
     def get():
         return "Hello, world!"
@@ -497,7 +497,7 @@ def post(request):
         return {"status_code": 200, "body": body}
 
 
-@app.view("/async_decorator_view")
+@app.view("/async/view/decorator")
 def async_decorator_view():
     async def get():
         return "Hello, world!"
@@ -518,6 +518,6 @@ async def post(request):
         index_file="index.html",
     )
     app.startup_handler(startup_handler)
-    app.add_view("/sync_view", SyncView)
-    app.add_view("/async_view", AsyncView)
+    app.add_view("/sync/view", SyncView)
+    app.add_view("/async/view", AsyncView)
     app.start(port=8080)
diff --git a/integration_tests/test_async_views.py b/integration_tests/test_async_views.py
diff --git a/integration_tests/test_sync_views.py b/integration_tests/test_sync_views.py
diff --git a/integration_tests/test_views.py b/integration_tests/test_views.py
@@ -0,0 +1,41 @@
+from helpers.http_methods_helpers import get, post
+
+
+def test_get_sync_view(session):
+    r = get("/sync/view")
+    assert r.text == "Hello, world!"
+
+
+def test_post_sync_view(session):
+    r = post("/sync/view", data={"name": "John"})
+    assert "John" in r.text
+
+
+def test_get_sync_decorator_view(session):
+    r = get("/sync/view/decorator")
+    assert r.text == "Hello, world!"
+
+
+def test_post_sync_decorator_view(session):
+    r = post("/sync/view/decorator", data={"name": "John"})
+    assert "John" in r.text
+
+
+def test_get_async_view(session):
+    r = get("/async/view")
+    assert r.text == "Hello, world!"
+
+
+def test_post_async_view(session):
+    r = post("/async/view", data={"name": "John"})
+    assert "John" in r.text
+
+
+def test_get_async_decorator_view(session):
+    r = get("/async/view/decorator")
+    assert r.text == "Hello, world!"
+
+
+def test_post_async_decorator_view(session):
+    r = post("/async/view/decorator", data={"name": "John"})
+    assert "John" in r.text
diff --git a/integration_tests/views/__init__.py b/integration_tests/views/__init__.py
@@ -1,4 +1,4 @@
-from .test_view import SyncView
+from .sync_view import SyncView
 from .async_view import AsyncView
 
 __all__ = ["SyncView", "AsyncView"]
diff --git a/integration_tests/views/test_view.py → integration_tests/views/sync_view.py b/integration_tests/views/test_view.py → integration_tests/views/sync_view.py
diff --git a/robyn/__init__.py b/robyn/__init__.py
@@ -40,11 +40,11 @@ def __init__(self, file_object: str) -> None:
 
     def _add_route(self, route_type, endpoint, handler, is_const=False):
         """
-        [This is base handler for all the decorators]
+        This is base handler for all the decorators
 
-        :param route_type [str]: [route type between GET/POST/PUT/DELETE/PATCH]
-        :param endpoint [str]: [endpoint for the route added]
-        :param handler [function]: [represents the sync or async function passed as a handler for the route]
+        :param route_type str: route type between GET/POST/PUT/DELETE/PATCH
+        :param endpoint str: endpoint for the route added
+        :param handler function: represents the sync or async function passed as a handler for the route
         """
 
         """ We will add the status code here only
@@ -168,10 +168,10 @@ def terminating_signal_handler(_sig, _frame):
 
     def add_view(self, endpoint: str, view: Callable, const: bool = False):
         """
-        [This is base handler for the view decorators]
+        This is base handler for the view decorators
 
-        :param endpoint [str]: [endpoint for the route added]
-        :param handler [function]: [represents the function passed as a parent handler for single route with different route types]
+        :param endpoint str: endpoint for the route added
+        :param handler function: represents the function passed as a parent handler for single route with different route types
         """
         http_methods = {"GET", "POST", "PUT", "DELETE", "PATCH", "HEAD", "OPTIONS"}
 
@@ -181,7 +181,7 @@ def get_functions(view):
             for name, handler in functions:
                 route_type = name.upper()
                 if route_type in http_methods:
-                    output.append((route_type.upper(), handler))
+                    output.append((route_type, handler))
             return output
 
         handlers = get_functions(view)